Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 916113 - sci-astronomy/stellarium-0.24.4 and dev-libs/qxlsx-1.5.0 stabilisation (was: sci-astronomy/stellarium depends on deprecated dev-qt/qtscript:5)
Summary: sci-astronomy/stellarium-0.24.4 and dev-libs/qxlsx-1.5.0 stabilisation (was: ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Stabilization (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Alexey
URL: https://github.com/Stellarium/stellar...
Whiteboard: scheduled for 2025-02-07
Keywords: CC-ARCHES
Depends on: 947182
Blocks: qtscript-removal
  Show dependency tree
 
Reported: 2023-10-22 09:56 UTC by Andreas Sturmlechner
Modified: 2025-02-26 20:28 UTC (History)
4 users (show)

See Also:
Package list:
sci-astronomy/stellarium-24.4 dev-libs/qxlsx-1.5.0
Runtime testing required: ---
nattka: sanity-check+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sturmlechner gentoo-dev 2023-10-22 09:56:30 UTC
Please use ENABLE_SCRIPT_QML in order to drop the deprecated package in favor of dev-qt/qtdeclarative:5.
Comment 1 Alexey 2023-10-22 09:58:59 UTC
Upstream doesn't actually support QML with Qt5. While technically such combination of options can be set in cmake, Qt5 build requires QtScript, and Qt6 build Requires QML
Comment 3 Andreas Sturmlechner gentoo-dev 2023-10-23 10:34:33 UTC
What's the problem there, test failures or build/runtime issues? Wouldn't upstream benefit from ironing out QML with Qt5 and being able to drop ifdefs throughout the codebase?
Comment 4 Alexey 2023-10-23 19:44:48 UTC
Test failures leading to runtime issues; build itself is fine. I opened https://github.com/Stellarium/stellarium/issues/3473
Comment 5 Andreas Sturmlechner gentoo-dev 2024-05-31 07:08:45 UTC
Any changes upstream?
Comment 6 Alexey 2024-08-01 23:27:52 UTC
No updates since October last year.

To summarize discussion in the upstream bug: QML has removed an optional feature which Stellarium was using with QtScript, so Stellarium upstream is recommending QtScript over QML, while Qt5 is still an option at all. At least until they figure out how to reimplement that feature with QML.

Additionally the Qt6 port has some unrelated bugs (in the telescope plugin), which was another reason why they've been recommending Qt5 over Qt6. They are fixing these bugs though.
Comment 7 Andreas Sturmlechner gentoo-dev 2024-12-31 11:58:19 UTC
hm, coming from https://github.com/gentoo/gentoo/pull/39916 - how far along the path to Qt6 are upstream by now?
Comment 8 Alexey 2024-12-31 12:09:07 UTC
No changes since last update wrt scripting. They made it more visible in UI that a part of TelescopeControl plugin doesn't work.

If you insist, we can still drop qt5 though, I think, and accept that some features will be lost for now.
Comment 9 Andreas Sturmlechner gentoo-dev 2024-12-31 18:30:31 UTC
I'll leave that up to you, as I can't make that judgement about how much of a loss it would be.

If we keep Qt5, then we should also keep qxlsx[qt5] option since a change like https://github.com/gentoo/gentoo/pull/39916/files#diff-cb0f13b038e6f80972040e8ce09d9b72c55c81001c5ed3524d8fb4b277595944R77 means we would be stuck on an old version of it without the ability to clean it up anyway.
Comment 10 Alexey 2024-12-31 19:01:21 UTC
Well, let's do it and check if anyone complains, in which case we can temporarily add it back... At least it would increase visibility that upstream needs help implementing these 2 features.
Comment 11 Larry the Git Cow gentoo-dev 2025-01-08 21:46:24 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a53d910a389ae356e666bb9af848f4cb0970fc4e

commit a53d910a389ae356e666bb9af848f4cb0970fc4e
Author:     Alexey Sokolov <alexey+gentoo@asokolov.org>
AuthorDate: 2024-12-23 23:46:06 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2025-01-08 21:34:40 +0000

    sci-astronomy/stellarium: add 24.4
    
    Disable qt5
    
    Bug: https://bugs.gentoo.org/916113
    Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
    Closes: https://github.com/gentoo/gentoo/pull/39834
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 sci-astronomy/stellarium/Manifest                  |   4 +
 .../files/stellarium-0.24.4-indilib.patch          |  52 ++++++
 sci-astronomy/stellarium/stellarium-24.4.ebuild    | 179 +++++++++++++++++++++
 3 files changed, 235 insertions(+)
Comment 12 NATTkA bot gentoo-dev Security 2025-01-23 21:29:39 UTC Comment hidden (obsolete)
Comment 13 NATTkA bot gentoo-dev Security 2025-01-23 21:32:40 UTC Comment hidden (obsolete)
Comment 14 NATTkA bot gentoo-dev Security 2025-01-23 21:56:54 UTC Comment hidden (obsolete)
Comment 15 NATTkA bot gentoo-dev Security 2025-01-24 10:01:01 UTC Comment hidden (obsolete)
Comment 16 Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2025-02-10 19:01:08 UTC
amd64 done
Comment 17 Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2025-02-10 20:10:49 UTC
ppc64 done

all arches done
Comment 18 Larry the Git Cow gentoo-dev 2025-02-26 20:28:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ca809dccf92b3d7adf85c86ebcf15b70ebf7a568

commit ca809dccf92b3d7adf85c86ebcf15b70ebf7a568
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2025-02-10 20:13:55 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2025-02-26 20:25:24 +0000

    dev-libs/qxlsx: drop 1.4.8
    
    Closes: https://bugs.gentoo.org/916113
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-libs/qxlsx/Manifest           |  1 -
 dev-libs/qxlsx/qxlsx-1.4.8.ebuild | 54 ---------------------------------------
 2 files changed, 55 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=06e0931f6adfb42d8eb78629851639cf2fc7a9d0

commit 06e0931f6adfb42d8eb78629851639cf2fc7a9d0
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2025-02-10 20:13:26 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2025-02-26 20:25:24 +0000

    sci-astronomy/stellarium: drop 24.3
    
    Closes: https://bugs.gentoo.org/916113
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 sci-astronomy/stellarium/Manifest                  |   5 -
 .../files/stellarium-0.24.3-fast_float.patch       |  23 ---
 .../files/stellarium-0.24.3-tbb-emit.patch         |  35 ----
 sci-astronomy/stellarium/stellarium-24.3.ebuild    | 216 ---------------------
 4 files changed, 279 deletions(-)