915977 – net-libs/webkit-gtk-2.42.1: security stabilization

Bug 915977 - net-libs/webkit-gtk-2.42.1: security stabilization

Summary: net-libs/webkit-gtk-2.42.1: security stabilization

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Stabilization (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Linux Gnome Desktop Team

URL:
Whiteboard:
Keywords:	CC-ARCHES, SECURITY

Depends on:
Blocks:	CVE-2023-35074, CVE-2023-39434, CVE-2023-39928, CVE-2023-40451, CVE-2023-41074, CVE-2023-41993, CVE-2023-42890, WSA-2023-0009
	Show dependency tree

Reported:	2023-10-18 20:36 UTC by Mart Raudsepp
Modified:	2023-12-24 15:10 UTC (History)
CC List:	2 users (show)

See Also:
Package list:	net-libs/webkit-gtk-2.42.1 net-libs/webkit-gtk-2.42.1-r410 net-libs/webkit-gtk-2.42.1-r600
Runtime testing required:	---

Flags:	nattka: sanity-check+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mart Raudsepp gentoo-dev

2023-10-18 20:36:50 UTC

Please stabilize

Comment 1 Sam James archtester

2023-10-30 10:43:10 UTC

arm64 done

Comment 2 Sam James archtester

2023-10-31 12:31:16 UTC

amd64 done

Comment 3 Arthur Zamarin archtester

2023-11-25 09:36:30 UTC

arm done

Comment 4 matoro archtester

2023-12-12 06:34:06 UTC

ppc64 done

Comment 5 matoro archtester

2023-12-19 21:11:50 UTC

None of these work on ppc, they require lock-free atomics

FAILED: Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/libANGLE/renderer/gl/BufferGL.cpp.o
/usr/bin/powerpc-unknown-linux-gnu-g++ -DANGLE_ENABLE_ESSL -DANGLE_ENABLE_GLSL -DANGLE_ENABLE_OPENGL -DANGLE_PLATFORM_LINUX -DBUILDING_GTK__=1 -DBUILDING_WEBKIT=1 -DBUILDING_WITH_CMAKE=1 -DBWR
AP_EXECUTABLE=\"/usr/bin/bwrap\" -DDBUS_PROXY_EXECUTABLE=\"/usr/bin/xdg-dbus-proxy\" -DEGL_EGL_PROTOTYPES=0 -DEGL_NO_PLATFORM_SPECIFIC_TYPES -DGETTEXT_PACKAGE=\"WebKitGTK-6.0\" -DGL_GLES_PROTO
TYPES=0 -DHAVE_CONFIG_H=1 -DJSC_GLIB_API_ENABLED -DLIBANGLE_IMPLEMENTATION -DPAS_BMALLOC=1 -DUSE_SYSTEM_EGL -I/var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1/Source/Thir
dParty/ANGLE/WebKit -I/var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1/Source/ThirdParty/ANGLE/include -I/var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2
.42.1/Source/ThirdParty/ANGLE/include/KHR -I/var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1/Source/ThirdParty/ANGLE/src -I/var/tmp/portage/net-libs/webkit-gtk-2.42.1-r60
0/work/webkitgtk-2.42.1/Source/ThirdParty/ANGLE/src/common/base -I/var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1/Source/ThirdParty/ANGLE/src/common/third_party/xxhash -
I/var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1/Source/ThirdParty/ANGLE/third_party/zlib/google -I/var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1
_build/Source/ThirdParty/ANGLE/include  -DNDEBUG -fdiagnostics-color=always -Wextra -Wall -pipe -fmax-errors=20 -Wno-odr -Wno-stringop-overread -Wno-stringop-overflow -Wno-nonnull -Wno-array-b
ounds -Wno-expansion-to-defined -Wno-noexcept-type -Wno-uninitialized -Wno-mismatched-new-delete -Wno-psabi -Wno-misleading-indentation -Wno-maybe-uninitialized -Wundef -Wpointer-arith -Wmissi
ng-format-attribute -Wformat-security -Wcast-align -Wno-tautological-compare -O2 -mcpu=powerpc -mtune=powerpc -pipe -fno-strict-aliasing -fno-exceptions -fno-rtti -std=c++20 -fPIC -fvisibility
=hidden -w -MD -MT Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/libANGLE/renderer/gl/BufferGL.cpp.o -MF Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/libANGLE/renderer/gl/BufferGL.cpp.o
.d -o Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/libANGLE/renderer/gl/BufferGL.cpp.o -c /var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1/Source/ThirdParty/ANGLE/src
/libANGLE/renderer/gl/BufferGL.cpp
In file included from /var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1/Source/ThirdParty/ANGLE/src/libANGLE/RefCountObject.h:20,
                 from /var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1/Source/ThirdParty/ANGLE/src/libANGLE/angletypes.h:19,
                 from /var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1/Source/ThirdParty/ANGLE/src/libANGLE/Caps.h:12,
                 from /var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1/Source/ThirdParty/ANGLE/src/libANGLE/Context.h:22,
                 from /var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/BufferGL.cpp:13:
/var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1/Source/ThirdParty/ANGLE/src/libANGLE/renderer/serial_utils.h:132:37: error: static assertion failed: Must always be lock
free
  132 |     static_assert(decltype(mValue)::is_always_lock_free, "Must always be lock free");
      |                   ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
ninja: build stopped: subcommand failed.

Comment 6 Branko Grubic 2023-12-19 22:43:16 UTC

(In reply to matoro from comment #5)
> None of these work on ppc, they require lock-free atomics
> 
> FAILED:
> Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/libANGLE/renderer/gl/
> BufferGL.cpp.o
> /usr/bin/powerpc-unknown-linux-gnu-g++ -DANGLE_ENABLE_ESSL
> -DANGLE_ENABLE_GLSL -DANGLE_ENABLE_OPENGL -DANGLE_PLATFORM_LINUX
> -DBUILDING_GTK__=1 -DBUILDING_WEBKIT=1 -DBUILDING_WITH_CMAKE=1 -DBWR
> AP_EXECUTABLE=\"/usr/bin/bwrap\"
> -DDBUS_PROXY_EXECUTABLE=\"/usr/bin/xdg-dbus-proxy\" -DEGL_EGL_PROTOTYPES=0
> -DEGL_NO_PLATFORM_SPECIFIC_TYPES -DGETTEXT_PACKAGE=\"WebKitGTK-6.0\"
> -DGL_GLES_PROTO
> TYPES=0 -DHAVE_CONFIG_H=1 -DJSC_GLIB_API_ENABLED -DLIBANGLE_IMPLEMENTATION
> -DPAS_BMALLOC=1 -DUSE_SYSTEM_EGL
> -I/var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1/
> Source/Thir
> dParty/ANGLE/WebKit
> -I/var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1/
> Source/ThirdParty/ANGLE/include
> -I/var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2
> .42.1/Source/ThirdParty/ANGLE/include/KHR
> -I/var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1/
> Source/ThirdParty/ANGLE/src -I/var/tmp/portage/net-libs/webkit-gtk-2.42.1-r60
> 0/work/webkitgtk-2.42.1/Source/ThirdParty/ANGLE/src/common/base
> -I/var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1/
> Source/ThirdParty/ANGLE/src/common/third_party/xxhash -
> I/var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1/
> Source/ThirdParty/ANGLE/third_party/zlib/google
> -I/var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1
> _build/Source/ThirdParty/ANGLE/include  -DNDEBUG -fdiagnostics-color=always
> -Wextra -Wall -pipe -fmax-errors=20 -Wno-odr -Wno-stringop-overread
> -Wno-stringop-overflow -Wno-nonnull -Wno-array-b
> ounds -Wno-expansion-to-defined -Wno-noexcept-type -Wno-uninitialized
> -Wno-mismatched-new-delete -Wno-psabi -Wno-misleading-indentation
> -Wno-maybe-uninitialized -Wundef -Wpointer-arith -Wmissi
> ng-format-attribute -Wformat-security -Wcast-align -Wno-tautological-compare
> -O2 -mcpu=powerpc -mtune=powerpc -pipe -fno-strict-aliasing -fno-exceptions
> -fno-rtti -std=c++20 -fPIC -fvisibility
> =hidden -w -MD -MT
> Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/libANGLE/renderer/gl/
> BufferGL.cpp.o -MF
> Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/libANGLE/renderer/gl/
> BufferGL.cpp.o
> .d -o
> Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/libANGLE/renderer/gl/
> BufferGL.cpp.o -c
> /var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1/
> Source/ThirdParty/ANGLE/src
> /libANGLE/renderer/gl/BufferGL.cpp
> In file included from
> /var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1/
> Source/ThirdParty/ANGLE/src/libANGLE/RefCountObject.h:20,
>                  from
> /var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1/
> Source/ThirdParty/ANGLE/src/libANGLE/angletypes.h:19,
>                  from
> /var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1/
> Source/ThirdParty/ANGLE/src/libANGLE/Caps.h:12,
>                  from
> /var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1/
> Source/ThirdParty/ANGLE/src/libANGLE/Context.h:22,
>                  from
> /var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1/
> Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/BufferGL.cpp:13:
> /var/tmp/portage/net-libs/webkit-gtk-2.42.1-r600/work/webkitgtk-2.42.1/
> Source/ThirdParty/ANGLE/src/libANGLE/renderer/serial_utils.h:132:37: error:
> static assertion failed: Must always be lock
> free
>   132 |     static_assert(decltype(mValue)::is_always_lock_free, "Must
> always be lock free");
>       |                   ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
> ninja: build stopped: subcommand failed.

On quick search there is an upstream bug and some external references here: https://bugs.webkit.org/show_bug.cgi?id=252670 ( https://github.com/google/angle/commit/ce8ce6f81eff8a84e2ea59930cb995b1107181e2 )

Comment 7 Mart Raudsepp gentoo-dev

2023-12-24 15:10:11 UTC

The 2.42.3 set got stabilized on the remaining arches by now instead as part of bug 919979.
Please file a separate bug if there's still issues re ppc atomics or otherwise.