Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 915686 - net-dialup/ppp - please don't purge 2.4.9 yet
Summary: net-dialup/ppp - please don't purge 2.4.9 yet
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal major (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: CVE-2022-4603
  Show dependency tree
 
Reported: 2023-10-13 14:33 UTC by Jaco Kroon
Modified: 2024-03-27 06:32 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jaco Kroon 2023-10-13 14:33:13 UTC
Hi,

A number of issues with 2.5.0 are seemingly cropping up upstream.  Most of them are benign but there are definite issues so we're still using 2.4.9 in highly sensitive places whilst sorting the issues in 2.5.0 one by one elsewhere.  Patches are going straight upstream.

This one issue is of particular annoyance and definitely not benign, seeing this everywhere we're using pptp and/or l2tp:

https://github.com/ppp-project/ppp/issues/453

This seems to look like an interoperability issue between 2.4.9 (client) and 2.5.0 (server) - for the common definition of client and server where ppp is more about peers than clients and servers.

Windows clients are also having problems connecting.  Rolling ppp back from 2.5.0 to 2.4.9 resolves the issues.

Don't think we need to unstable ppp 2.5.0, but we need to please not purge 2.4.9 since there are definitely still cases where it works when 2.5.0 doesn't.

Reproducible: Always
Comment 1 Mike Gilbert gentoo-dev 2023-10-13 16:33:13 UTC
Noted.
Comment 2 Mike Gilbert gentoo-dev 2024-03-05 19:55:05 UTC
Any updates here?
Comment 3 Jaco Kroon 2024-03-06 05:52:05 UTC
The core bugs necessitating this request has been fixed, but I haven't yet updated the last two systems still using 2.4.9 but I think from a Gentoo perspective it can go now.  If needed I'll move it into our private ::uls repo.

Thanks for keeping it around as long as you have, appreciate the effort.

Kind regards,
Jaco
Comment 4 Mike Gilbert gentoo-dev 2024-03-10 16:17:19 UTC
(In reply to Jaco Kroon from comment #3)

Do we need to backport any patches for 2.5.0 in the Gentoo ebuild? If you can point me to them I am happy to do that.
Comment 5 Jaco Kroon 2024-03-11 07:34:14 UTC
https://github.com/ppp-project/ppp/pull/463

I've been applying locally on machines as I roll out, but obviously having this "upstream" is preferred.
Comment 6 Larry the Git Cow gentoo-dev 2024-03-27 00:10:53 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fb8a1f91bb2425e9a871ac5bad40bb925a53732a

commit fb8a1f91bb2425e9a871ac5bad40bb925a53732a
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2024-03-26 23:01:45 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2024-03-27 00:10:11 +0000

    net-dialup/ppp: backport radius mppe fix
    
    Closes: https://bugs.gentoo.org/915686
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 net-dialup/ppp/files/ppp-2.5.0-radius-mppe.patch   | 167 +++++++++++++++++++++
 .../{ppp-2.5.0-r6.ebuild => ppp-2.5.0-r7.ebuild}   |   3 +-
 2 files changed, 169 insertions(+), 1 deletion(-)
Comment 7 Jaco Kroon 2024-03-27 06:32:36 UTC
Hi Mike,

Just my expression of gratitude in a generally ungrateful world, appreciate the effort from yourself thank you.

I notice this went straight to stable, which also makes my life a lot easier w.r.t. internal patch management on this side thank you.

Kind regards,
Jaco