Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 915573 - [guru] net-p2p/feather-2.6.2 overwrites CFLAGS/CXXFLAGS or adds uncommon ones
Summary: [guru] net-p2p/feather-2.6.2 overwrites CFLAGS/CXXFLAGS or adds uncommon ones
Status: RESOLVED OBSOLETE
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Adam
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qa-guru
  Show dependency tree
 
Reported: 2023-10-11 06:44 UTC by Agostino Sarubbo
Modified: 2024-07-16 06:56 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,832.56 KB, text/plain)
2023-10-11 06:44 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-10-11 06:44:00 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-p2p/feather-2.4.9-r1 overwrites CFLAGS/CXXFLAGS or adds uncommon ones.
Discovered on: amd64 (internal ref: guru_ci)

NOTE:
This QA check is tinderbox-only, there is the list of the flags that should be dropped out, if you think it is a false positive please let me know.
Comment 1 Agostino Sarubbo gentoo-dev 2023-10-11 06:44:03 UTC
Created attachment 872527 [details]
build.log

build log and emerge --info
Comment 2 Mike 2023-10-11 14:27:51 UTC
I think net-p2p/feather-2.4.9-r1 should depend on dev-qt/qtwebsockets:6 as well.

Could anyone please update the dependencies list of feather?
Comment 3 Mike 2023-10-11 14:30:20 UTC
For me, feather does not compile if I don't have dev-qt/qtwebsockets:6 already emerged.

https://github.com/gentoo/guru/blob/master/net-p2p/feather/feather-2.4.9-r1.ebuild

I have "qt6" enabled as global USE flag.
Comment 4 Adam 2023-10-11 16:05:30 UTC
(In reply to Mike from comment #3)
> For me, feather does not compile if I don't have dev-qt/qtwebsockets:6
> already emerged.
> 
> https://github.com/gentoo/guru/blob/master/net-p2p/feather/feather-2.4.9-r1.
> ebuild
> 
> I have "qt6" enabled as global USE flag.

Sorry about that, feather switched over to qt6, and I asked the developer to keep qt5 because qt6 wasnt ready on gentoo.

See https://github.com/feather-wallet/feather/blob/8212d40ea3144f5dfcf1394f17833cdb59181feb/src/CMakeLists.txt#L20 it looks like it's failing because it is just checking if you have qt6 version of qtsvg and then assuming you have all the packages as qt6.

But you're right it should have a qt6/qt5 USE flag. I'll add it in the 2.5.0 ebuild.

It still looks like a bunch of the qt6 packages like this https://packages.gentoo.org/packages/dev-qt/qtcore aren't in gentoo, but some like qtwebsockets are? https://packages.gentoo.org/packages/dev-qt/qtwebsockets
Comment 5 Viorel Munteanu gentoo-dev 2023-10-11 16:15:07 UTC
(In reply to Mike from comment #2)
> I think net-p2p/feather-2.4.9-r1 should depend on dev-qt/qtwebsockets:6 as
> well.
> 
> Could anyone please update the dependencies list of feather?

Please file the qt6 situation as a separate bug, it has nothing to do with the current bug.
Comment 6 Viorel Munteanu gentoo-dev 2023-10-11 16:18:27 UTC
(In reply to Adam from comment #4)
> But you're right it should have a qt6/qt5 USE flag. I'll add it in the 2.5.0
> ebuild.
> 
> It still looks like a bunch of the qt6 packages like this
> https://packages.gentoo.org/packages/dev-qt/qtcore aren't in gentoo, but
> some like qtwebsockets are?
> https://packages.gentoo.org/packages/dev-qt/qtwebsockets

QT6 is structured differently, look into dev-qt/qtbase and dev-qt/qttools for a start.
Comment 7 Adam 2023-10-11 18:30:32 UTC
Mike, Viorel, do you mind taking a look at my 2.5.0 ebuild? I'm not familiar with qt6 but this ebuild seems to work for me when I enable USE=qt6 in my make.conf 

https://github.com/gentoo/guru/commit/bb40d304d282f68749c19db18cf57e141a6e9740

https://github.com/gentoo/guru/commit/b1f13448f805454577392a34b6af4ac501a60bc9

on an unrelated note, I keep messing up my commits by not pushing the changes to the Manifest. Is that caused by me doing `git pull` and resetting the Manifest file?
Comment 8 Agostino Sarubbo gentoo-dev 2024-01-04 10:05:45 UTC
guru_ci has reproduced this issue with version 2.6.2 - Updating summary.
Comment 9 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-07-16 06:56:54 UTC
PKGREMOVED is for if the package is entirely removed, not a specific version.