Bug 915469 – media-gfx/exiv2-0.28.0 fails to compile (lto): minoltamn_int.cpp:1653:18: error: type ‘struct LensIdFct’ violates the C++ One Definition Rule [-Werror=odr]

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description ppw0 2023-10-09 10:38:03 UTC]

Created attachment 872370 [details]
build log

In a stricter lto environment, media-gfx/exiv2-0.28.0 will fail to compile with the following error message:
```
/var/tmp/portage/media-gfx/exiv2-0.28.0/work/exiv2-0.28.0/src/minoltamn_int.cpp:1653:18: error: type ‘struct LensIdFct’ violates the C++ One Definition Rule [-Werror=odr]
 1653 | constexpr struct LensIdFct {
      |                  ^
/var/tmp/portage/media-gfx/exiv2-0.28.0/work/exiv2-0.28.0/src/pentaxmn_int.cpp:1234:8: note: a different type is defined in another translation unit
 1234 | struct LensIdFct {
      |        ^
/var/tmp/portage/media-gfx/exiv2-0.28.0/work/exiv2-0.28.0/src/minoltamn_int.cpp:1654:12: note: the first difference of corresponding definitions is field ‘idx’
 1654 |   uint32_t idx;
      |            ^
/var/tmp/portage/media-gfx/exiv2-0.28.0/work/exiv2-0.28.0/src/pentaxmn_int.cpp:1235:8: note: a field with different name is defined in another translation unit
 1235 |   long id_;       //!< Lens id
      |        ^
lto1: some warnings being treated as errors
lto-wrapper: fatal error: /usr/bin/x86_64-pc-linux-gnu-g++ returned 1 exit status
compilation terminated.
/usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
```

Attaching logs.

[Comment 1 ppw0 2023-10-09 10:39:01 UTC]

Created attachment 872371 [details]
emerge --info

[Comment 2 Andreas Sturmlechner 2023-11-13 22:13:25 UTC]

what about 0.28.1?

[Comment 3 ppw0 2023-11-14 10:36:35 UTC]

Created attachment 874726 [details]
build log (0.28.1)

0.28.1 looks ok.

[Comment 4 Andreas Sturmlechner 2023-11-14 20:17:47 UTC]

great, then this bug can be closed.