Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 91540 - kde-base/kdelibs with optional dnotify
Summary: kde-base/kdelibs with optional dnotify
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All All
: Normal minor (vote)
Assignee: Gentoo/BSD Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 93587
  Show dependency tree
 
Reported: 2005-05-05 01:59 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2006-04-12 10:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
kdelibs-3.4.0-r2.patch (kdelibs-3.4.0-r2.patch,1.12 KB, patch)
2005-05-05 01:59 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2005-05-05 01:59:07 UTC
Currently kdelibs forces enabled dnotify, which is a linux-specific thing. As we have kernel_linux useflag now, the attached patch enables it only on linux systems, so that we are able to compile kde on g/fbsd.

I've also added a fam useflag to make optional the fam support, also if that is going to be enabled by quite everyone, having it optional seems a better solution to me.

HTH, Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-05-05 01:59:32 UTC
Created attachment 58113 [details, diff]
kdelibs-3.4.0-r2.patch
Comment 2 Dan Armak (RETIRED) gentoo-dev 2005-05-25 13:34:39 UTC
Where's the kernel_linux flag? It's not in use.desc and repoman says it's 
invalid, and there' no other ebuild in the tree that uses it... Do we actually 
have it, or is it just planned? 
If/when it exists we can apply the dnotify patch. 
 
As for fam, despite the use.defaults entry, a new system won't have it enabled, 
and I wouldn't want to change the effective default behaviour to disabling fam 
support :-/ 
 
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-05-25 13:48:14 UTC
kernel_* is USE_EXPANDed from KERNEL variable in make.defaults. 
 
About fam.. yeah that's also true... maybe that can just be avoided for now. 
 
Comment 4 Gregorio Guidi (RETIRED) gentoo-dev 2005-05-26 01:40:49 UTC
Fixed the kernel_linux thing in kdelibs-3.4.1.  
I agree that we should not add fam unless it becomes a default use flag.