Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 915237 - net-im/telegram-desktop-4.8.4-r2: error: ‘avifImageMirror’ {aka ‘struct avifImageMirror’} has no member named ‘mode’
Summary: net-im/telegram-desktop-4.8.4-r2: error: ‘avifImageMirror’ {aka ‘struct avifI...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Esteve Varela Colominas
URL:
Whiteboard:
Keywords: PATCH
Depends on: 915992
Blocks:
  Show dependency tree
 
Reported: 2023-10-06 11:04 UTC by Andrew Ammerlaan
Modified: 2023-12-11 13:25 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (build.log,155.87 KB, text/plain)
2023-10-06 11:05 UTC, Andrew Ammerlaan
Details
tdesktop-4.8.4-libavif-1.0.patch (tdesktop-4.8.4-libavif-1.0.patch,887 bytes, patch)
2023-10-06 22:22 UTC, Andrey Volkov
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Ammerlaan gentoo-dev 2023-10-06 11:04:16 UTC
FAILED: cmake/external/kimageformats/CMakeFiles/external_kimageformats.dir/__/__/__/Telegram/ThirdParty/kimageformats/src/imageformats/avif.cpp.o
/usr/bin/x86_64-pc-linux-gnu-g++ -DAVIF_DLL -DDESKTOP_APP_DISABLE_CRASH_REPORTS -DDESKTOP_APP_USE_PACKAGED -DKIMG_JXL_API_VERSION=70 -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_DEPRECATED_WARNINGS_SINCE=0x051500 -DQT_GUI_LIB -DQT_IMPLICIT_QCHAR_CONSTRUCTION -DQT_NETWORK_LIB -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_DEBUG -DQT_NO_KEYWORDS -DQT_OPENGLWIDGETS_LIB -DQT_OPENGL_LIB -DQT_QMLINTEGRATION_LIB -DQT_QMLMODELS_LIB -DQT_QML_LIB -DQT_QUICKWIDGETS_LIB -DQT_QUICK_LIB -DQT_STATICPLUGIN -DQT_SVG_LIB -DQT_WIDGETS_LIB -isystem /usr/include/qt6/QtCore -isystem /usr/include/qt6 -isystem /usr/lib64/qt6/mkspecs/linux-g++ -isystem /usr/include/qt6/QtCore/6.5.3 -isystem /usr/include/qt6/QtCore/6.5.3/QtCore -isystem /usr/include/qt6/QtGui -isystem /usr/include/qt6/QtGui/6.5.3 -isystem /usr/include/qt6/QtGui/6.5.3/QtGui -isystem /usr/include/qt6/QtOpenGL -isystem /usr/include/qt6/QtWidgets -isystem /usr/include/qt6/QtWidgets/6.5.3 -isystem /usr/include/qt6/QtWidgets/6.5.3/QtWidgets -isystem /usr/include/qt6/QtOpenGLWidgets -isystem /usr/include/qt6/QtNetwork -isystem /usr/include/qt6/QtSvg -isystem /usr/include/qt6/QtDBus -isystem /usr/include/qt6/QtQml -isystem /usr/include/qt6/QtQmlIntegration -isystem /usr/include/qt6/QtQuick -isystem /usr/include/qt6/QtQmlModels -isystem /usr/include/qt6/QtQuickWidgets  -DNDEBUG -O2 -pipe -march=skylake -mtune=skylake -std=gnu++20 -fPIC -fno-strict-aliasing -pipe -Wall -Wextra -Wno-unused-parameter-Wno-switch -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-sign-compare -Wno-deprecated -DHWY_SHARED_DEFINE -MD -MT cmake/external/kimageformats/CMakeFiles/external_kimageformats.dir/__/__/__/Telegram/ThirdParty/kimageformats/src/imageformats/avif.cpp.o -MF cmake/external/kimageformats/CMakeFiles/external_kimageformats.dir/__/__/__/Telegram/ThirdParty/kimageformats/src/imageformats/avif.cpp.o.d -o cmake/external/kimageformats/CMakeFiles/external_kimageformats.dir/__/__/__/Telegram/ThirdParty/kimageformats/src/imageformats/avif.cpp.o -c /tmp/portage/net-im/telegram-desktop-4.8.4-r2/work/tdesktop-4.8.4-full/Telegram/ThirdParty/kimageformats/src/imageformats/avif.cpp
/tmp/portage/net-im/telegram-desktop-4.8.4-r2/work/tdesktop-4.8.4-full/Telegram/ThirdParty/kimageformats/src/imageformats/avif.cpp: In member function ‘bool QAVIFHandler::decode_one_frame()’:
/tmp/portage/net-im/telegram-desktop-4.8.4-r2/work/tdesktop-4.8.4-full/Telegram/ThirdParty/kimageformats/src/imageformats/avif.cpp:428:40: error: ‘avifImageMirror’ {aka ‘struct avifImageMirror’} has no member named ‘mode’
428 |         switch (m_decoder->image->imir.mode) {
|
Comment 1 Andrew Ammerlaan gentoo-dev 2023-10-06 11:05:31 UTC
Created attachment 872217 [details]
build log
Comment 2 Andrey Volkov 2023-10-06 22:22:45 UTC
Created attachment 872249 [details, diff]
tdesktop-4.8.4-libavif-1.0.patch

Fixed upstream kimageformats-5.110.0-rc1

https://github.com/KDE/kimageformats/commit/bcec942cc92e0968c724a2c1f92b4cd048bf8fa7.patch

included in tdesktop-v4.9.4
Comment 3 Jorge 2023-10-11 12:20:50 UTC
Hi.  With the attached patch, last Sunday and Monday I merged =net-im/telegram-desktop-4.8.4-r2 on two Gentoo GNU/Linux AMD64 machines and it went smoothly.  I don't use Telegram much, but it seems to be working OK.  I have not specifically tested AVIF support.  Both machines are Intel Core i7; one is Tiger Lake, the other much older.  I have applied the patch by simply dropping it into the /etc/portage/patches/net-im/telegram-desktop/ directory, which I created.
Comment 4 Andrew Ammerlaan gentoo-dev 2023-10-11 13:08:44 UTC
Can't reproduce this on my machine any more either
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-10-11 13:11:05 UTC
(In reply to Andrew Ammerlaan from comment #4)
> Can't reproduce this on my machine any more either

The user above was, I think, confirming the patch works for them, not saying they can't repro?
Comment 6 Esteve Varela Colominas 2023-10-11 13:23:41 UTC
I'm mostly wondering whether this patch is still necessary on 4.10.3.
Comment 7 Andrew Ammerlaan gentoo-dev 2023-10-11 13:32:07 UTC
(In reply to Esteve Varela Colominas from comment #6)
> I'm mostly wondering whether this patch is still necessary on 4.10.3.

It isn't, this is what I meant when I said I couldn't reproduce this any more. 

Sorry, my message was very unclear.
Comment 8 Larry the Git Cow gentoo-dev 2023-12-11 13:25:55 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7497d83f469b739fcc81775878c5e59c2000e5c8

commit 7497d83f469b739fcc81775878c5e59c2000e5c8
Author:     Esteve Varela Colominas <esteve.varela@gmail.com>
AuthorDate: 2023-12-10 22:30:20 +0000
Commit:     Yixun Lan <dlan@gentoo.org>
CommitDate: 2023-12-11 13:23:32 +0000

    net-im/telegram-desktop: Drop stable
    
    The list of bugs has become untenable, the package is essentially
    unusable, and there's no clear idea of when glibmm will be bumped.
    
    Sorry for the inconveniences...
    
    Bug: https://bugs.gentoo.org/915992
    Closes: https://bugs.gentoo.org/877067
    Closes: https://bugs.gentoo.org/910544
    Closes: https://bugs.gentoo.org/911395
    Closes: https://bugs.gentoo.org/912896
    Closes: https://bugs.gentoo.org/914419
    Closes: https://bugs.gentoo.org/914902
    Closes: https://bugs.gentoo.org/915109
    Closes: https://bugs.gentoo.org/915237
    Closes: https://bugs.gentoo.org/915982
    Signed-off-by: Esteve Varela Colominas <esteve.varela@gmail.com>
    Signed-off-by: Yixun Lan <dlan@gentoo.org>

 net-im/telegram-desktop/Manifest                   |   1 -
 .../files/tdesktop-4.4.1-fix-dupe-main-decl.patch  |  26 ---
 .../telegram-desktop-4.8.1-r3.ebuild               | 210 ---------------------
 3 files changed, 237 deletions(-)