Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 914581 - dev-qt/qtlocation-5.15.10: fails to build with gcc 14 (error: assignment of read-only location)
Summary: dev-qt/qtlocation-5.15.10: fails to build with gcc 14 (error: assignment of r...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Qt Bug Alias
URL: https://invent.kde.org/qt/qt/qtlocati...
Whiteboard:
Keywords: PATCH, UPSTREAM
Depends on:
Blocks: gcc-14 915383
  Show dependency tree
 
Reported: 2023-09-24 00:50 UTC by Sam James
Modified: 2023-10-08 14:10 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (file_914581.txt,889.27 KB, text/plain)
2023-09-24 00:50 UTC, Sam James
Details
qtlocation-5.15-mapbox-gl-native-gcc-14-const-operator.patch (file_914581.txt,1.02 KB, patch)
2023-09-24 00:51 UTC, Sam James
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-09-24 00:50:41 UTC
Created attachment 871210 [details]
build.log

In file included from /var/tmp/portage/dev-qt/qtlocation-5.15.10/work/qtlocation-everywhere-src-5.15.10/src/3rdparty/mapbox-gl-native/src/mbgl/util/rapidjson.hpp:3,
                 from /var/tmp/portage/dev-qt/qtlocation-5.15.10/work/qtlocation-everywhere-src-5.15.10/src/3rdparty/mapbox-gl-native/src/mbgl/style/conversion/stringify.hpp:10,
                 from /var/tmp/portage/dev-qt/qtlocation-5.15.10/work/qtlocation-everywhere-src-5.15.10/src/3rdparty/mapbox-gl-native/src/mbgl/style/properties.hpp:4,
                 from /var/tmp/portage/dev-qt/qtlocation-5.15.10/work/qtlocation-everywhere-src-5.15.10/src/3rdparty/mapbox-gl-native/src/mbgl/style/paint_property.hpp:4,
                 from /var/tmp/portage/dev-qt/qtlocation-5.15.10/work/qtlocation-everywhere-src-5.15.10/src/3rdparty/mapbox-gl-native/src/mbgl/programs/program.hpp:9,
                 from /var/tmp/portage/dev-qt/qtlocation-5.15.10/work/qtlocation-everywhere-src-5.15.10/src/3rdparty/mapbox-gl-native/src/mbgl/programs/heatmap_texture_program.hpp:3,
                 from /var/tmp/portage/dev-qt/qtlocation-5.15.10/work/qtlocation-everywhere-src-5.15.10/src/3rdparty/mapbox-gl-native/src/mbgl/programs/heatmap_texture_program.cpp:1:
/var/tmp/portage/dev-qt/qtlocation-5.15.10/work/qtlocation-everywhere-src-5.15.10/src/3rdparty/mapbox-gl-native/deps/rapidjson/1.1.0/include/rapidjson/document.h: In member function ‘rapidjson::GenericStringRef<CharType>& rapidjson::GenericStringRef<CharType>::operator=(const rapidjson::GenericStringRef<CharType>&)’:
/var/tmp/portage/dev-qt/qtlocation-5.15.10/work/qtlocation-everywhere-src-5.15.10/src/3rdparty/mapbox-gl-native/deps/rapidjson/1.1.0/include/rapidjson/document.h:319:82: error: assignment of read-only location ‘((rapidjson::GenericStringRef<CharType>*)this)->rapidjson::GenericStringRef<CharType>::length’
  319 |     GenericStringRef& operator=(const GenericStringRef& rhs) { s = rhs.s; length = rhs.length; }
      |                                                                           ~~~~~~~^~~~~~~~~~~~
make: *** [Makefile:22361: .obj/src/mbgl/programs/heatmap_texture_program.o] Error 1
make: *** Waiting for unfinished jobs....
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-09-24 00:51:01 UTC
negril spotted the patch is https://github.com/Tencent/rapidjson/commit/3b2441b87f99ab65f37b141a7b548ebadb607b96.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-09-24 00:51:56 UTC
Created attachment 871211 [details, diff]
qtlocation-5.15-mapbox-gl-native-gcc-14-const-operator.patch
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-09-24 00:54:02 UTC
Note that I'm not going to bother trying to upstream this one after how https://codereview.qt-project.org/c/qt/qtlocation/+/454093 went.
Comment 4 Andreas Sturmlechner gentoo-dev 2023-09-25 08:08:35 UTC
Let's try a different upstream then?
Comment 5 Larry the Git Cow gentoo-dev 2023-09-26 10:02:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c05fedbbc9a038058a634815b88fcf19df7ad396

commit c05fedbbc9a038058a634815b88fcf19df7ad396
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-09-26 09:12:22 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-09-26 10:01:39 +0000

    dev-qt/qtlocation: Fix build with GCC-14
    
    Bumping mapbox-gl-native to 4c88f2c0e61daa89f584a8a9a3eba210221c6920.
    
    Closes: https://bugs.gentoo.org/914581
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-qt/qtlocation/Manifest                     |  1 +
 dev-qt/qtlocation/qtlocation-5.15.10-r1.ebuild | 58 ++++++++++++++++++++++++++
 2 files changed, 59 insertions(+)
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-09-26 15:10:44 UTC
thank you for handling it!