Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 913488 - inconsistent application of graphicsmagick/imagemagick USE flags
Summary: inconsistent application of graphicsmagick/imagemagick USE flags
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-02 10:23 UTC by ta2002
Modified: 2023-09-15 03:02 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ta2002 2023-09-02 10:23:27 UTC
Yes, the ebuild clearly states it:

# both must be enabled to use GraphicsMagick
if use imagemagick && use graphicsmagick; then
    myeconfargs+=(
        --with-graphicsmagick
        --without-imagemagick
    )
elif ! use graphicsmagick && use imagemagick; then
    myeconfargs+=(
        --with-imagemagick
        --without-graphicsmagick
    )

But every other ebuild that allows either graphicsmagick or imagemagick forces the user to choose one or the other. It doesn't make sense to require -graphicsmagick and +imagemagick for imagemagick, while requiring +graphicsmagick AND +imagemagick for graphicsmagick. The ebuild should allow only one of graphicsmagick or imagemagick (and obviously build "--with-graphicsmagick" with USE=+graphicsmagick.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-09-02 10:25:49 UTC
It does make sense - this is how we handle every other package.

imagemagick is the feature, graphicsmagick is the provider. See https://bugs.gentoo.org/314431#c28.

For the case where IM usage (regardless of the provider) is optional, you have an additional USE=imagemagick.
Comment 2 ta2002 2023-09-15 02:59:32 UTC
Reopening this, because if you have correctly described the preferred methodology, then (at least) these two packages don't follow that syntax.

app-misc/graphlcd-base-2.0.3-r3:

REQUIRED_USE="?? ( graphicsmagick imagemagick )"


media-video/dvdauthor-0.7.2-r2:

REQUIRED_USE="^^ ( graphicsmagick imagemagick )"
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-09-15 03:02:39 UTC
(In reply to ta2002 from comment #2)
> Reopening this, because if you have correctly described the preferred
> methodology, then (at least) these two packages don't follow that syntax.
> 
> app-misc/graphlcd-base-2.0.3-r3:
> 
> REQUIRED_USE="?? ( graphicsmagick imagemagick )"
> 
> 
> media-video/dvdauthor-0.7.2-r2:
> 
> REQUIRED_USE="^^ ( graphicsmagick imagemagick )"

Please file a new bug for each.