Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 912834 - media-gfx/gthumb-3.12.2-r5: Needs patch to work with media-gfx/exiv2-0.28.0
Summary: media-gfx/gthumb-3.12.2-r5: Needs patch to work with media-gfx/exiv2-0.28.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: https://gitlab.gnome.org/GNOME/gthumb...
Whiteboard: fixed in 3.12.3
Keywords: PATCH
: 925707 (view as bug list)
Depends on:
Blocks: exiv2-0.28
  Show dependency tree
 
Reported: 2023-08-22 13:17 UTC by Bernd Feige
Modified: 2024-04-20 12:48 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Patch from https://gitlab.archlinux.org/archlinux/packaging/packages/gthumb/-/raw/362ccadb79f5f4aeca7fa7d2b07047fe9055dd18/exiv2-0.28.patch (exiv2-0.28.patch,11.58 KB, patch)
2023-08-22 13:20 UTC, Bernd Feige 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bernd Feige 2023-08-22 13:17:52 UTC 
With media-gfx/exiv2-0.28.0, gthumb compilation fails:

../gthumb-3.12.2/extensions/exiv2_tools/exiv2-utils.cpp:743:1: error: variable or field ‘exiv2_read_metadata’ declared void
  743 | exiv2_read_metadata (Exiv2::Image::AutoPtr  image,
      | ^~~~~~~~~~~~~~~~~~~
../gthumb-3.12.2/extensions/exiv2_tools/exiv2-utils.cpp:743:36: error: ‘AutoPtr’ is not a member of ‘Exiv2::Image’
  743 | exiv2_read_metadata (Exiv2::Image::AutoPtr  image,

...

The patch provided in https://gitlab.archlinux.org/archlinux/packaging/packages/gthumb/-/raw/362ccadb79f5f4aeca7fa7d2b07047fe9055dd18/exiv2-0.28.patch fixes it.

Reproducible: Always
Comment 2 Geoff Leach 2023-08-22 20:40:00 UTC 
works for me
Comment 3 Dominique Michel 2023-08-24 13:36:06 UTC 
works for me too
Comment 4 Andreas Sturmlechner gentoo-dev 2023-09-03 08:13:26 UTC 
What about 3.12.3 (~arch) though?
Comment 5 Matt Turner gentoo-dev 2023-09-04 22:00:18 UTC 
(In reply to Andreas Sturmlechner from comment #4)
> What about 3.12.3 (~arch) though?

Yep, works fine. The upstream commit linked was included in 3.12.3, which is why I dropped it from the 3.12.3 ebuild.
Comment 6 Andreas Sturmlechner gentoo-dev 2024-04-20 12:48:25 UTC 
*** Bug 925707 has been marked as a duplicate of this bug. ***