Created attachment 867186 [details] make.conf 'eselect editor list' output doesn't list vim (app-editors/vim) Steps to reproduce: -------------------- Environment: Fresh install, still chrooted from the livecd with USE="... vim-syntax ..." in make.conf. Vim is installed as a dependency of 'app-vim/eselect-syntax' due to USE="... vim-syntax ..." in make.conf. But vim doesn't show up in the output of 'eselect editor list'. Also Verified: Vim doesn't show in 'eselect editor list' output even if installed manually. (chroot) livecd / # eselect editor list Available targets for the EDITOR variable: [1] ex [2] vi [ ] (free form)
Created attachment 867187 [details] packages in the systemset
Created attachment 867188 [details] packages in the world-set
This is one of those things which feels surprising but it's so surprising that I feel like I've got to be missing something as to why it's not there. $ grep -rsin nano . modules/visual.eselect:8:EDITOR_LIST="nano emacs vi xemacs" modules/editor.eselect:8:EDITOR_LIST="nano ed emacs ex vi xemacs"
(In reply to Sam James from comment #3) > This is one of those things which feels surprising but it's so surprising > that I feel like I've got to be missing something as to why it's not there. At the limit could think it's because there's eselect-vi (or app-alternatives/vi if that ever got finished), and then "vi" covers about everything. Unless of course you want vi to be something else then use vim as EDITOR. Given how widespread vim is, I do feel it should be in there though.
There is eselect-vi which allows to choose between 11 vi variants, and IMHO it wouldn't make much sense to add all of them to the editor module. Similarly, the editor module lists neither single GNU Emacs slots nor any of the 14 micro-emacs variants. Furthermore, you can select vim with the "free form" option: # eselect editor set vim Setting EDITOR to vim ... Run ". /etc/profile" to update the variable in your shell. # eselect editor list Available targets for the EDITOR variable: [1] nano [2] ed [3] emacs [4] ex [5] vi [6] xemacs [7] vim * [ ] (free form)
I think it isn't clear to most users that emacs and vi are further controlled via eselect-{emacs,vi}. So the output needs to make that clear in some way. Maybe add the effective link for both to the output? Like: [3] emacs (/usr/bin/emacs -> emacs-29) via eselect-emacs [5] vi (/usr/bin/vi -> vim) via eselect-vi Or use: [3] eselect-emacs [5] eselect-vi
That being said, we have virtual/editor and everything that satisfies that should show up in eselect-editor.
Previously I was asked to reduce the list to its bare minimum, so e.g. pico and zile were dropped from it. The preset values are only there so that "eselect editor update" will have some reasonable default choices, when the currently eselected package is removed. Any other user preference can be set via the "free form" entry (see comment #5). That said, patches for the editor.eselect(5) manpage are welcome.
(In reply to Ulrich Müller from comment #8) > Previously I was asked to reduce the list to its bare minimum, so e.g. pico > and zile were dropped from it. The preset values are only there so that > "eselect editor update" will have some reasonable default choices, when the > currently eselected package is removed. Any other user preference can be set > via the "free form" entry (see comment #5). > By who/why? I still don't see why not.
I still don't see anything in bug 190216 which says 'vim', as an extremely popular choice, would be inappropriate.
Created attachment 867274 [details, diff] Update lists in editor and visual modules Let's revert the list to what was originally suggested in bug 190216 comment #2, keeping only the most possible choices. Few people will be using ed and ex although they're mandated by POSIX, and I guess that XEmacs is less popular in 2023 than it was in 2009.
CCing maintainers of app-editors/xemacs, app-eselect/eselect-vi and sys-apps/ed.
wfm. anyone who cares about ex/ed will know how to set it, I hope ;)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/eselect.git/commit/?id=e1577d699cfc3eb60b245c8488062a43e8cece22 commit e1577d699cfc3eb60b245c8488062a43e8cece22 Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2023-08-07 16:21:04 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2023-08-07 16:21:04 +0000 Update lists in editor and visual modules * modules/editor.eselect (EDITOR_LIST): * modules/visual.eselect (EDITOR_LIST): Add vim; drop ed, ex, vi and xemacs. Bug 911792. Bug: https://bugs.gentoo.org/911792 Signed-off-by: Ulrich Müller <ulm@gentoo.org> ChangeLog | 6 ++++++ modules/editor.eselect | 4 ++-- modules/visual.eselect | 4 ++-- 3 files changed, 10 insertions(+), 4 deletions(-)
(In reply to Ulrich Müller from comment #11) > Created attachment 867274 [details, diff] [details, diff] > Update lists in editor and visual modules Great work, thank you. > Let's revert the list to what was originally suggested in bug 190216 comment > #2, keeping only the most possible choices. Sounds good, this works for me.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=94c143cfc308eb0f883cd7d3ee2c036db76e3f10 commit 94c143cfc308eb0f883cd7d3ee2c036db76e3f10 Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2023-08-09 15:33:16 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2023-08-09 15:39:19 +0000 app-admin/eselect: add 1.4.26 Closes: https://bugs.gentoo.org/911792 Signed-off-by: Ulrich Müller <ulm@gentoo.org> app-admin/eselect/Manifest | 1 + app-admin/eselect/eselect-1.4.26.ebuild | 63 +++++++++++++++++++++++++++++++++ 2 files changed, 64 insertions(+)
