Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 911617 - net-nntp/nzbget: switch to maintained fork
Summary: net-nntp/nzbget: switch to maintained fork
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Joe Kappus
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-02 16:12 UTC by Sam James
Modified: 2024-07-17 11:27 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-08-02 16:12:29 UTC
https://github.com/nzbget/nzbget is archived, but I came across an active fork at https://github.com/nzbget-ng/nzbget.

Could the ebuild be changed over to this? Cheers.
Comment 1 Joe Kappus 2023-09-20 18:26:49 UTC
Since this has been open for some time I'll work on this and offer to proxy maintain it. I am familiar with the software and a heavy usenet user (used to use this before going to sabnzbd). Sven, just so I don't step on your toes if you still want it just reassign to yourself.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-09-20 18:47:32 UTC
Putting swegener into CC.
Comment 3 Louis Sautier (sbraz) gentoo-dev 2023-09-23 23:49:00 UTC
(In reply to Joe Kappus from comment #1)
> Since this has been open for some time I'll work on this and offer to proxy
> maintain it. I am familiar with the software and a heavy usenet user (used
> to use this before going to sabnzbd). Sven, just so I don't step on your
> toes if you still want it just reassign to yourself.

Hi, Sven hasn't touched the ebuild since 2016. I have been maintaining it since then.
I just didn't feel like changing upstreams before being sure that the new one was trustworthy. Have you tried it yet? I guess we could release upstream's v21.4-rc2 as 21.4_pre2. It's too bad the new maintainer didn't update the changelog though.
I don't mind co-maintainers, feel free to make a PR and add yourself.
Comment 4 Louis Sautier (sbraz) gentoo-dev 2023-10-30 22:47:58 UTC
It came to my attention that there is another fork: https://github.com/nzbgetcom/nzbget
What do you guys think?
Comment 5 Joe Kappus 2023-11-05 21:08:59 UTC
That fork might actually be better to target, here's their discussion/philosophy on it: https://github.com/nzbgetcom/nzbget/discussions/37 and reddit release announcement: https://www.reddit.com/r/usenet/comments/17k0tda/new_nzbget_project/

nzbget's had a longstanding issue where it can't de-obfuscate nzb releases posted by a certain group. nzbget-ng can but it also breaks support for BSD OS's. This new fork seems to have taken a more planned/conservative approach to support new hardware/OS and leaves handling the de-obfuscation task to an external script. 

Yeah, we should probably use this one instead.
Comment 6 Larry the Git Cow gentoo-dev 2024-07-17 01:09:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=54e661770fa7c07f2e661accd98b71c4e73ad4fd

commit 54e661770fa7c07f2e661accd98b71c4e73ad4fd
Author:     Louis Sautier <sbraz@gentoo.org>
AuthorDate: 2024-07-14 14:33:45 +0000
Commit:     Louis Sautier <sbraz@gentoo.org>
CommitDate: 2024-07-17 01:08:07 +0000

    net-nntp/nzbget: add 24.1 from new nzbget.com fork, #911617
    
    https://github.com/nzbget/nzbget has been archived since 2022.
    We initially thought of switching to https://github.com/nzbget-ng/nzbget
    but https://github.com/nzbgetcom/nzbget seems more active.
    
    Closes: https://bugs.gentoo.org/911617
    Signed-off-by: Louis Sautier <sbraz@gentoo.org>

 net-nntp/nzbget/Manifest                           |   1 +
 .../nzbget/files/nzbget-24.1-fix-allocah.patch     |  39 ++++++++
 net-nntp/nzbget/metadata.xml                       |   5 +-
 net-nntp/nzbget/nzbget-24.1.ebuild                 | 110 +++++++++++++++++++++
 4 files changed, 152 insertions(+), 3 deletions(-)
Comment 7 Joe Kappus 2024-07-17 05:09:54 UTC
Thanks for getting that done, I had this updated in my overlay for some weeks just forgot to update the bug.
Comment 8 Louis Sautier (sbraz) gentoo-dev 2024-07-17 11:27:17 UTC
(In reply to Joe Kappus from comment #7)
> Thanks for getting that done, I had this updated in my overlay for some
> weeks just forgot to update the bug.

You're welcome :) I tested it for a few weeks before eventually committing it to the tree. It took a while to switch to the CMake-based build but now we should be good for a few years!
I did check your overlay's version (didn't realise it was yours when I did). If you see anything in the current ebuild that seems missing, please let me know, here, on IRC or by email, whichever is most convenient.