Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 911481 - dev-libs/capstone-9999 adds -Werror flag on its own (9999-SYSTEM)
Summary: dev-libs/capstone-9999 adds -Werror flag on its own (9999-SYSTEM)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: mario.haustein
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2023-07-29 19:42 UTC by Agostino Sarubbo
Modified: 2023-08-28 04:05 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,134.12 KB, application/x-xz)
2023-07-29 19:42 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-07-29 19:42:41 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/capstone-9999 adds -Werror flag on its own (9999-SYSTEM).
Discovered on: amd64 (internal ref: 9999_tinderbox)

NOTE:
(9999-SYSTEM) in the summary means that the bug was found on a STANDARD machine that tries the 9999 version of the ebuild. While bugs about 9999 version make sense until certain point, you should see it as a way to know in advance what will have in the future release.
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.
Comment 1 Agostino Sarubbo gentoo-dev 2023-07-29 19:42:44 UTC
Created attachment 866637 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Comment 2 Larry the Git Cow gentoo-dev 2023-08-28 04:05:45 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f8ca69dcc50e60f841b3288e662a388800f6fd58

commit f8ca69dcc50e60f841b3288e662a388800f6fd58
Author:     Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
AuthorDate: 2023-08-27 16:47:20 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-08-28 04:03:46 +0000

    dev-libs/capstone: don't add -Werror to compiler options
    
    Closes: https://bugs.gentoo.org/911481
    Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
    Closes: https://github.com/gentoo/gentoo/pull/32478
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/capstone/capstone-9999.ebuild             |  7 +++++++
 dev-libs/capstone/files/capstone-9999-werror.patch | 13 +++++++++++++
 2 files changed, 20 insertions(+)