Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 911111 - [guru] dev-libs/mtxclient-0.9.2 overwrites CFLAGS/CXXFLAGS or adds uncommon ones
Summary: [guru] dev-libs/mtxclient-0.9.2 overwrites CFLAGS/CXXFLAGS or adds uncommon ones
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: tea
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qa-guru
  Show dependency tree
 
Reported: 2023-07-24 06:45 UTC by Agostino Sarubbo
Modified: 2023-07-25 04:59 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,208.97 KB, text/plain)
2023-07-24 06:45 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-07-24 06:45:12 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/mtxclient-0.9.2 overwrites CFLAGS/CXXFLAGS or adds uncommon ones.
Discovered on: amd64 (internal ref: guru_ci)

NOTE:
This QA check is tinderbox-only, there is the list of the flags that should be dropped out, if you think it is a false positive please let me know.
Comment 1 Agostino Sarubbo gentoo-dev 2023-07-24 06:45:14 UTC
Created attachment 866045 [details]
build.log

build log and emerge --info
Comment 2 tea 2023-07-24 10:20:52 UTC
the fix to this was removed in bcc7513b14e8e4be58e71383a8737f6df9c0902d by cybertailor. i don't know why, so i'm cc-ing you.

i personally don't think it matters much if the flag is disable-able or not but others disagree.
Comment 3 Anna Vyalkova 2023-07-24 14:01:48 UTC
> i don't know why, so i'm cc-ing you

PIE is unconditionally enabled in Gentoo toolchain, see:
https://wiki.gentoo.org/wiki/Hardened/Toolchain

Added "-DCMAKE_POSITION_INDEPENDENT_CODE=OFF" back.

Also, congrats with a pretty bug number xD
Comment 4 tea 2023-07-24 14:23:07 UTC
(In reply to Anna Vyalkova from comment #3)
> PIE is unconditionally enabled in Gentoo toolchain, see:
> https://wiki.gentoo.org/wiki/Hardened/Toolchain

that seems to be only true with USE="hardened"?

> Added "-DCMAKE_POSITION_INDEPENDENT_CODE=OFF" back.
> 
> Also, congrats with a pretty bug number xD

😎
Comment 5 Anna Vyalkova 2023-07-24 15:00:06 UTC
(In reply to tastytea from comment #4)
> that seems to be only true with USE="hardened"?

No, it's enabled in "Vanilla / normal Gentoo" (see the table).
Comment 6 Larry the Git Cow gentoo-dev 2023-07-25 04:59:36 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=4f141e90648218ad58acd62d57cc86ccd09cc900

commit 4f141e90648218ad58acd62d57cc86ccd09cc900
Author:     Anna (cybertailor) Vyalkova <cyber+gentoo@sysrq.in>
AuthorDate: 2023-07-24 14:00:15 +0000
Commit:     Anna (cybertailor) Vyalkova <cyber+gentoo@sysrq.in>
CommitDate: 2023-07-24 14:00:30 +0000

    dev-libs/mtxclient: disable -fPIE
    
    Closes: https://bugs.gentoo.org/911111
    Signed-off-by: Anna (cybertailor) Vyalkova <cyber+gentoo@sysrq.in>

 dev-libs/mtxclient/mtxclient-0.9.2.ebuild | 1 +
 1 file changed, 1 insertion(+)