Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 910045 - www-client/pybugz: needs to use PEP517 build (DistutilsNonPEP517Build)
Summary: www-client/pybugz: needs to use PEP517 build (DistutilsNonPEP517Build)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: William Hubbs
URL:
Whiteboard:
Keywords: PullRequest
: 922479 (view as bug list)
Depends on:
Blocks: pep517-porting
  Show dependency tree
 
Reported: 2023-07-08 06:58 UTC by Michał Górny
Modified: 2024-02-15 17:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 06:58:48 UTC
This package still uses the legacy eclass code paths.  These paths are deprecated and pose a significant maintenance cost.  Please update the package to use PEP517 build mode.  For more information, please see the Python Guide, particularly; https://projects.gentoo.org/python/guide/migration.html#migrating-to-pep-517-builds
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 20:40:55 UTC
[Adding this comment en-masse, sorry for the noise, but it's important.)

1. Please take particular care to check file diffs before/after, possibly using `iwdevtools`. Keep a particular eye out for e.g. config files now missing from /etc and instead being in /usr/lib/python*/site-packages, etc.

2. Please make sure to do the migration in a new revision in ~arch, partly because of 1.
Comment 2 William Hubbs gentoo-dev 2023-07-13 20:19:50 UTC
@mgorny:
Does the guide show what I need to do in this package upstream to make
this change, or can you open a pr upstream for me to make the change?

Thanks,

William
Comment 3 Eli Schwartz 2024-02-04 04:28:32 UTC
*** Bug 922479 has been marked as a duplicate of this bug. ***
Comment 4 Larry the Git Cow gentoo-dev 2024-02-15 17:53:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1cebce95d40bfab03d5c92b06750b77d201be31c

commit 1cebce95d40bfab03d5c92b06750b77d201be31c
Author:     Eli Schwartz <eschwartz93@gmail.com>
AuthorDate: 2024-02-04 04:23:27 +0000
Commit:     William Hubbs <williamh@gentoo.org>
CommitDate: 2024-02-15 17:52:30 +0000

    www-client/pybugz: multiple small fixes
    
    - remove extraneous dependencies on setuptools
    
    The distutils eclass already handles this correctly. This includes using
    BDEPEND instead of DEPEND.
    
    Avoids a runtime dependency on setuptools, which has never been used --
    in general software never uses `import setuptools` at runtime, and
    pybugz doesn't actually make use of pkg_resources either.
    
    - migrate to pep517 build
    - update EAPI 7 -> 8
    
    Closes: https://bugs.gentoo.org/910045
    Closes: https://github.com/gentoo/gentoo/pull/35177
    
    Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
    Signed-off-by: William Hubbs <williamh@gentoo.org>

 www-client/pybugz/pybugz-0.13-r3.ebuild | 32 ++++++++++++++++++++++++++++++++
 www-client/pybugz/pybugz-9999.ebuild    | 10 ++++------
 2 files changed, 36 insertions(+), 6 deletions(-)