Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 910014 - net-voip/sipvicious: needs to use PEP517 build (DistutilsNonPEP517Build)
Summary: net-voip/sipvicious: needs to use PEP517 build (DistutilsNonPEP517Build)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Jaco Kroon
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: pep517-porting
  Show dependency tree
 
Reported: 2023-07-08 06:58 UTC by Michał Górny
Modified: 2023-09-22 08:32 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 06:58:03 UTC
This package still uses the legacy eclass code paths.  These paths are deprecated and pose a significant maintenance cost.  Please update the package to use PEP517 build mode.  For more information, please see the Python Guide, particularly; https://projects.gentoo.org/python/guide/migration.html#migrating-to-pep-517-builds
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 20:40:54 UTC
[Adding this comment en-masse, sorry for the noise, but it's important.)

1. Please take particular care to check file diffs before/after, possibly using `iwdevtools`. Keep a particular eye out for e.g. config files now missing from /etc and instead being in /usr/lib/python*/site-packages, etc.

2. Please make sure to do the migration in a new revision in ~arch, partly because of 1.
Comment 2 Jaco Kroon 2023-08-30 21:27:56 UTC
diff on equery files before and after migration.

Confirmed package is still operational.

--- /tmp/sipvicious_pre_files.txt	2023-08-30 23:19:34.592508540 +0200
+++ /tmp/sipvicious_post_files.txt	2023-08-30 23:20:40.562535205 +0200
@@ -9,13 +9,12 @@
 /usr/lib/python3.11
 /usr/lib/python3.11/site-packages
 /usr/lib/python3.11/site-packages/sipvicious
-/usr/lib/python3.11/site-packages/sipvicious-0.3.4-py3.11.egg-info
-/usr/lib/python3.11/site-packages/sipvicious-0.3.4-py3.11.egg-info/PKG-INFO
-/usr/lib/python3.11/site-packages/sipvicious-0.3.4-py3.11.egg-info/SOURCES.txt
-/usr/lib/python3.11/site-packages/sipvicious-0.3.4-py3.11.egg-info/dependency_links.txt
-/usr/lib/python3.11/site-packages/sipvicious-0.3.4-py3.11.egg-info/entry_points.txt
-/usr/lib/python3.11/site-packages/sipvicious-0.3.4-py3.11.egg-info/not-zip-safe
-/usr/lib/python3.11/site-packages/sipvicious-0.3.4-py3.11.egg-info/top_level.txt
+/usr/lib/python3.11/site-packages/sipvicious-0.3.4.dist-info
+/usr/lib/python3.11/site-packages/sipvicious-0.3.4.dist-info/METADATA
+/usr/lib/python3.11/site-packages/sipvicious-0.3.4.dist-info/RECORD
+/usr/lib/python3.11/site-packages/sipvicious-0.3.4.dist-info/WHEEL
+/usr/lib/python3.11/site-packages/sipvicious-0.3.4.dist-info/entry_points.txt
+/usr/lib/python3.11/site-packages/sipvicious-0.3.4.dist-info/top_level.txt
 /usr/lib/python3.11/site-packages/sipvicious/__init__.py
 /usr/lib/python3.11/site-packages/sipvicious/__pycache__
 /usr/lib/python3.11/site-packages/sipvicious/__pycache__/__init__.cpython-311.opt-1.pyc
@@ -57,10 +56,10 @@
 /usr/lib/python3.11/site-packages/sipvicious/svwar.py
 /usr/share
 /usr/share/doc
-/usr/share/doc/sipvicious-0.3.4
-/usr/share/doc/sipvicious-0.3.4/README.md.bz2
-/usr/share/doc/sipvicious-0.3.4/THANKS.bz2
-/usr/share/doc/sipvicious-0.3.4/TODO
+/usr/share/doc/sipvicious-0.3.4-r1
+/usr/share/doc/sipvicious-0.3.4-r1/README.md.bz2
+/usr/share/doc/sipvicious-0.3.4-r1/THANKS.bz2
+/usr/share/doc/sipvicious-0.3.4-r1/TODO
 /usr/share/man
 /usr/share/man/man1
 /usr/share/man/man1/svcrack.1.bz2
Comment 3 Larry the Git Cow gentoo-dev 2023-09-22 08:32:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1a33da47e59649895b62ba70111a3d046c06685a

commit 1a33da47e59649895b62ba70111a3d046c06685a
Author:     Jaco Kroon <jaco@uls.co.za>
AuthorDate: 2023-08-30 21:26:57 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-09-22 08:31:02 +0000

    net-voip/sipvicious: 0.3.4-r1 (PEP517).
    
    Closes: https://bugs.gentoo.org/910014
    Signed-off-by: Jaco Kroon <jaco@uls.co.za>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 net-voip/sipvicious/sipvicious-0.3.4-r1.ebuild | 29 ++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)