Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 909980 - dev-build/gyp (needed by app-i18n/mozc): needs to use PEP517 build (DistutilsNonPEP517Build)
Summary: dev-build/gyp (needed by app-i18n/mozc): needs to use PEP517 build (Distutils...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal
Assignee: CJK Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: pep517-porting
  Show dependency tree
 
Reported: 2023-07-08 06:56 UTC by Michał Górny
Modified: 2025-04-09 13:47 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 06:56:58 UTC
This package still uses the legacy eclass code paths.  These paths are deprecated and pose a significant maintenance cost.  Please update the package to use PEP517 build mode.  For more information, please see the Python Guide, particularly; https://projects.gentoo.org/python/guide/migration.html#migrating-to-pep-517-builds
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 20:40:51 UTC
[Adding this comment en-masse, sorry for the noise, but it's important.)

1. Please take particular care to check file diffs before/after, possibly using `iwdevtools`. Keep a particular eye out for e.g. config files now missing from /etc and instead being in /usr/lib/python*/site-packages, etc.

2. Please make sure to do the migration in a new revision in ~arch, partly because of 1.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-03-06 15:30:19 UTC
Final ping.  Please note that we will not hesitate to last rite low profile packages over this.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2025-03-22 20:18:22 UTC
Absolutely final ping before I really start last riting stuff.
Comment 4 Larry the Git Cow gentoo-dev 2025-03-31 17:33:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6cc9b02ac62bfb6d4e83be553e683aaa0a6948e6

commit 6cc9b02ac62bfb6d4e83be553e683aaa0a6948e6
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2025-03-31 17:19:31 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-03-31 17:32:00 +0000

    dev-build/gyp: port to python-single-r1
    
    The package isn't suitable for PEP517, as it installs data files and
    it simply happens to be written in Python, rather than intending to be
    imported and so on.
    
    Unfortunately, for the remaining PEP517 holdouts, there's little pressure
    upstream for them to port to a proper build system yet, as while setuptools
    deprecated the `setup.py` entrypoint some time ago, there's no removal
    in sight yet, so the only pressing side is on Gentoo's where we want
    to cleanup distutils-r1's support for that.
    
    It was arguably a mistake to really have these packages use distutils-r1
    in the first place.
    
    The obvious workaround for now is to invoke setup.py manually w/ python-single-r1,
    and punt the question until setuptools removal of the entrypoint looks
    closer (at which time, other distros will be putting pressure on upstreams
    too). Of course, if at the time of such a setuptools change, the package
    is still not fixed, then we'd have to remove it.
    
    (The same issues apply to bug #922396 which isn't fixed by this, but
    hopefully won't be an actual problem until that aforementioned removal
    in setuptools itself of the other bits.)
    
    Bug: https://bugs.gentoo.org/922396
    Closes: https://bugs.gentoo.org/909980
    Closes: https://bugs.gentoo.org/923435
    Closes: https://bugs.gentoo.org/952274
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-build/gyp/gyp-20200512145953-r1.ebuild | 67 ++++++++++++++++++++++++++++++
 dev-build/gyp/gyp-99999999999999.ebuild    | 48 +++++++++++++--------
 2 files changed, 98 insertions(+), 17 deletions(-)
Comment 5 Larry the Git Cow gentoo-dev 2025-04-09 13:47:35 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=23ed76400f3836f7d9362e3aeed14ebc615805a5

commit 23ed76400f3836f7d9362e3aeed14ebc615805a5
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2025-04-09 13:45:18 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-04-09 13:46:56 +0000

    dev-build/gyp: drop 20200512145953
    
    Bug: https://bugs.gentoo.org/909980
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-build/gyp/gyp-20200512145953.ebuild | 53 ---------------------------------
 1 file changed, 53 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3b70d8b1976075dd5f7c86c3b0ff6cb818b38e78

commit 3b70d8b1976075dd5f7c86c3b0ff6cb818b38e78
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2025-04-09 13:45:12 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-04-09 13:46:55 +0000

    dev-build/gyp: stabilize 20200512145953-r1 for amd64, ppc64, x86
    
    Bug: https://bugs.gentoo.org/909980
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-build/gyp/gyp-20200512145953-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)