Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 909929 - dev-python/progressbar: needs to use PEP517 build (DistutilsNonPEP517Build)
Summary: dev-python/progressbar: needs to use PEP517 build (DistutilsNonPEP517Build)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords: PMASKED
Depends on:
Blocks: pep517-porting
  Show dependency tree
 
Reported: 2023-07-08 06:49 UTC by Michał Górny
Modified: 2023-08-23 12:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 06:49:55 UTC
This package still uses the legacy eclass code paths.  These paths are deprecated and pose a significant maintenance cost.  Please update the package to use PEP517 build mode.  For more information, please see the Python Guide, particularly; https://projects.gentoo.org/python/guide/migration.html#migrating-to-pep-517-builds
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 14:48:40 UTC
FWICS this one doesn't have tests and only revdep (gcp).  Soap's going to check if we can replace it with progressbar2 there.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 16:58:43 UTC
In any case, this doesn't look like something we want to keep in ::gentoo.  Either gcp is migrated to a properly maintained library (tqdm, ideally, we don't really need more NIH packages) or we'll probably remove it.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 20:40:55 UTC
[Adding this comment en-masse, sorry for the noise, but it's important.)

1. Please take particular care to check file diffs before/after, possibly using `iwdevtools`. Keep a particular eye out for e.g. config files now missing from /etc and instead being in /usr/lib/python*/site-packages, etc.

2. Please make sure to do the migration in a new revision in ~arch, partly because of 1.
Comment 4 Larry the Git Cow gentoo-dev 2023-07-22 15:35:25 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fdc648cd4196c078d13a0c76c89402b16a08ac2e

commit fdc648cd4196c078d13a0c76c89402b16a08ac2e
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2023-07-22 15:35:18 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2023-07-22 15:35:18 +0000

    package.mask: Last rite dev-python/progressbar, sys-apps/gcp
    
    Bug: https://bugs.gentoo.org/909929
    Bug: https://bugs.gentoo.org/910031
    Signed-off-by: David Seifert <soap@gentoo.org>

 profiles/package.mask | 7 +++++++
 1 file changed, 7 insertions(+)
Comment 5 Larry the Git Cow gentoo-dev 2023-08-23 12:27:42 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b92c60d72112b5ccdd5409e0d50d74b5393b3b7b

commit b92c60d72112b5ccdd5409e0d50d74b5393b3b7b
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2023-08-23 12:27:30 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2023-08-23 12:27:30 +0000

    dev-python/progressbar: treeclean
    
    Closes: https://bugs.gentoo.org/909929
    Signed-off-by: David Seifert <soap@gentoo.org>

 dev-python/progressbar/Manifest               |  1 -
 dev-python/progressbar/metadata.xml           | 11 -----------
 dev-python/progressbar/progressbar-2.5.ebuild | 15 ---------------
 profiles/package.mask                         |  6 ------
 4 files changed, 33 deletions(-)