Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 909870 - app-editors/retext: needs to use PEP517 build (DistutilsNonPEP517Build)
Summary: app-editors/retext: needs to use PEP517 build (DistutilsNonPEP517Build)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Philipp Rösner
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: pep517-porting
  Show dependency tree
 
Reported: 2023-07-08 06:45 UTC by Michał Górny
Modified: 2023-08-14 07:02 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 06:45:15 UTC
This package still uses the legacy eclass code paths.  These paths are deprecated and pose a significant maintenance cost.  Please update the package to use PEP517 build mode.  For more information, please see the Python Guide, particularly; https://projects.gentoo.org/python/guide/migration.html#migrating-to-pep-517-builds
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 20:40:53 UTC
[Adding this comment en-masse, sorry for the noise, but it's important.)

1. Please take particular care to check file diffs before/after, possibly using `iwdevtools`. Keep a particular eye out for e.g. config files now missing from /etc and instead being in /usr/lib/python*/site-packages, etc.

2. Please make sure to do the migration in a new revision in ~arch, partly because of 1.
Comment 2 Larry the Git Cow gentoo-dev 2023-08-14 07:02:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=76ec5569b77264e9ad158faf15d8f2c6a0a250b6

commit 76ec5569b77264e9ad158faf15d8f2c6a0a250b6
Author:     Philipp Rösner <rndxelement@protonmail.com>
AuthorDate: 2023-07-26 14:35:25 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-08-14 07:02:28 +0000

    app-editors/retext: add 8.0.1 with pep517 support
    
    Add an ebuild for app-editors/retext-8.0.1 with support
    for PEP517 using the setuptools backend.
    Create a new .desktop file because the setup.py script
    removes the .desktop file in case of a wheel build.
    
    Closes: https://bugs.gentoo.org/909870
    Signed-off-by: Philipp Rösner <rndxelement@protonmail.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 app-editors/retext/Manifest            |  1 +
 app-editors/retext/retext-8.0.1.ebuild | 78 ++++++++++++++++++++++++++++++++++
 2 files changed, 79 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=514824518d83a1eaf42b6512972980d238e2feaf

commit 514824518d83a1eaf42b6512972980d238e2feaf
Author:     Philipp Rösner <rndxelement@protonmail.com>
AuthorDate: 2023-07-26 14:42:25 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-08-14 07:02:28 +0000

    app-editors/retext: pep517 support for live ebuild
    
    Add support for PEP517 using the setuptools backend for
    the live ebuild of app-editors/retext.
    
    Bug: https://bugs.gentoo.org/909870
    Signed-off-by: Philipp Rösner <rndxelement@protonmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/32054
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 app-editors/retext/retext-9999.ebuild | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)