Bug 909446 – kde-plasma/plasma-vault-5.27.6 fails to compile (lto): kded/engine/backends/cryfs/cryfsbackend.cpp:33:12: error: type ‘PlasmaVault::ExitCode’ violates the C++ One Definition Rule [-Werror=odr]

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Kostadin Shishmanov 2023-07-01 15:31:24 UTC]

Created attachment 864975 [details]
build log

kde-plasma/plasma-vault-5.27.6 fails to compile with -flto -Werror=odr added to CFLAGS and CXXFLAGS

/var/tmp/portage/kde-plasma/plasma-vault-5.27.6/work/plasma-vault-5.27.6/kded/engine/backends/cryfs/cryfsbackend.cpp:33:12: error: type ‘PlasmaVault::ExitCode’ violates the C++ One Definition Rule [-Werror=odr]
   33 | enum class ExitCode : int {
      |            ^
/var/tmp/portage/kde-plasma/plasma-vault-5.27.6/work/plasma-vault-5.27.6/kded/engine/backends/gocryptfs/gocryptfsbackend.cpp:32:12: note: an enum with different value name is defined in another translation unit
   32 | enum class ExitCode : int {
      |            ^
/var/tmp/portage/kde-plasma/plasma-vault-5.27.6/work/plasma-vault-5.27.6/kded/engine/backends/cryfs/cryfsbackend.cpp:37:5: note: name ‘UnspecifiedError’ differs from name ‘NonEmptyCipherDir’ defined in another translation unit
   37 |     UnspecifiedError = 1,
      |     ^
/var/tmp/portage/kde-plasma/plasma-vault-5.27.6/work/plasma-vault-5.27.6/kded/engine/backends/gocryptfs/gocryptfsbackend.cpp:36:5: note: mismatching definition
   36 |     NonEmptyCipherDir = 6,
      |     ^
lto1: some warnings being treated as errors
lto-wrapper: fatal error: /usr/bin/x86_64-pc-linux-gnu-g++ returned 1 exit status
compilation terminated.
/usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status

[Comment 1 Sam James 2023-07-01 15:32:13 UTC]

We really need to see if we can remove cryfs entirely really, as the new versions are hard to package (conan..).

[Comment 2 Arniii 2024-01-19 13:27:58 UTC]

reproducible with plasma-vault-5.27.10

[Comment 3 Paolo Pedroni 2024-02-12 16:40:54 UTC]

Same thing in 5.27.10

[Comment 4 Larry the Git Cow 2024-02-28 22:33:54 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=391896628d04bd9c8910b96b1270257f503d2878

commit 391896628d04bd9c8910b96b1270257f503d2878
Author:     Sam James <[e-mail]>
AuthorDate: 2024-02-28 22:32:45 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-02-28 22:32:45 +0000

    kde-plasma/plasma-vault: filter LTO (ODR violations)
    
    We really need to see if we can remove cryfs entirely really,
    as the new versions are hard to package (conan..).
    
    KDE-bug: https://bugs.kde.org/show_bug.cgi?id=471836
    Closes: https://bugs.gentoo.org/909446
    Signed-off-by: Sam James <[e-mail]>

 kde-plasma/plasma-vault/plasma-vault-5.27.10.ebuild | 5 ++++-
 kde-plasma/plasma-vault/plasma-vault-6.0.0.ebuild   | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

[Comment 5 Larry the Git Cow 2024-02-28 22:34:50 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=a4d528629033a354ddb7f91b1a9628360aad4ac1

commit a4d528629033a354ddb7f91b1a9628360aad4ac1
Author:     Sam James <[e-mail]>
AuthorDate: 2024-02-28 22:32:45 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-02-28 22:34:48 +0000

    kde-plasma/plasma-vault: filter LTO (ODR violations)
    
    We really need to see if we can remove cryfs entirely really,
    as the new versions are hard to package (conan..).
    
    KDE-bug: https://bugs.kde.org/show_bug.cgi?id=471836
    Closes: https://bugs.gentoo.org/909446
    Signed-off-by: Sam James <[e-mail]>

 kde-plasma/plasma-vault/plasma-vault-6.0.49.9999.ebuild | 5 ++++-
 kde-plasma/plasma-vault/plasma-vault-9999.ebuild        | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)