1.54.0 upgraded abseil to 20230125.2
on a site note, is the specific version really required? I know it's hardcoded in the CMakeFile, but it could be an artificial requirement. I know nothing about it, but libreoffice (a much more complex software) doesn't require a specific version and works with either. Please check if it could be removed in the next version. Thanks
It's worth checking, but keep in mind that grpc is googleware and so is abseil. They have a history of wanting the latest changes from related modules. It's not the same as LO.
1.55 appears to require >=protobuf-22, 1.56 >=23.
This is the ideal opportunity to use a bundled abseil in whatever version grpc wants to use, which in turn will reduce many related problems.
(In reply to Holger Hoffstätte from comment #4) > This is the ideal opportunity to use a bundled abseil in whatever version > grpc wants to use, which in turn will reduce many related problems. And possibly use a bundled re2 while we're at it, though that can be a second step.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=61d0b43d739b703ee9f25abefb04ba0bdf1ac158 commit 61d0b43d739b703ee9f25abefb04ba0bdf1ac158 Author: Sam James <sam@gentoo.org> AuthorDate: 2023-08-21 15:03:41 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-08-21 15:23:21 +0000 net-libs/grpc: bundle abseil-cpp abseil isn't *really* intended to be a system library and having a year-old pinned dep like this causes havoc for other packages and leads to uninstallable combinations (e.g. libreoffice-bin + anything needing grpc). Please see also the extensive discussion in the linked PRs wrt abseil now depending on re2 and the ABI implications of the used C++ std. versions with abseil. It's not worth it and there's more downsides to unbundling than not. Note that we can't rebundle re2 here because the build system unconditionally then tries to install it (no toggle unlike for abseil-cpp). Bug: https://bugs.gentoo.org/906811 Bug: https://github.com/gentoo/gentoo/pull/31388 Bug: https://github.com/gentoo/gentoo/pull/31609 Bug: https://github.com/gentoo/gentoo/pull/31893 Bug: https://github.com/gentoo/gentoo/pull/32281 Closes: https://bugs.gentoo.org/908373 Signed-off-by: Sam James <sam@gentoo.org> net-libs/grpc/Manifest | 1 + .../grpc/{grpc-1.52.1.ebuild => grpc-1.52.1-r1.ebuild} | 17 +++++++++++++---- 2 files changed, 14 insertions(+), 4 deletions(-)
(In reply to Holger Hoffstätte from comment #5) > (In reply to Holger Hoffstätte from comment #4) > > This is the ideal opportunity to use a bundled abseil in whatever version > > grpc wants to use, which in turn will reduce many related problems. > > And possibly use a bundled re2 while we're at it, though that can be a > second step. I tried and failed, as it tries to install it.
Lemme reopen this for the bump so I can get that done as well, or I'll forget.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ca082bdd4768c1eada06c19fbd76cffb8352a067 commit ca082bdd4768c1eada06c19fbd76cffb8352a067 Author: Sam James <sam@gentoo.org> AuthorDate: 2023-08-21 15:25:12 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-08-21 15:51:09 +0000 app-office/libreoffice: bundle abseil-cpp abseil isn't *really* intended to be a system library and having a year-old pinned dep like this causes havoc for other packages and leads to uninstallable combinations (e.g. libreoffice-bin + anything needing grpc). Please see also the extensive discussion in the linked PRs wrt abseil now depending on re2 and the ABI implications of the used C++ std. versions with abseil. It's not worth it and there's more downsides to unbundling than not. Bug: https://github.com/gentoo/gentoo/pull/31388 Bug: https://github.com/gentoo/gentoo/pull/31609 Bug: https://github.com/gentoo/gentoo/pull/31893 Bug: https://github.com/gentoo/gentoo/pull/32281 Bug: https://bugs.gentoo.org/908373 Closes: https://bugs.gentoo.org/912686 Signed-off-by: Sam James <sam@gentoo.org> app-office/libreoffice/libreoffice-7.5.9999.ebuild | 3 +-- app-office/libreoffice/libreoffice-9999.ebuild | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-)
grpc-1.52.1-r1 seems to break the installation of protobuf generator plugins. With 1.52.1, I have the following binaries installed by the package: /usr/bin/grpc_csharp_plugin /usr/bin/grpc_php_plugin /usr/bin/grpc_node_plugin /usr/bin/grpc_python_plugin /usr/bin/grpc_objective_c_plugin /usr/bin/grpc_ruby_plugin /usr/bin/grpc_cpp_plugin With 1.52.1-r1, the binaries aren't installed anymore. This breaks code generation from .proto files. Maybe something to do with the "-DgRPC_INSTALL=OFF" cmake argument that was added in -r1?
(In reply to Remy Blank from comment #10) > grpc-1.52.1-r1 seems to break the installation of protobuf generator > plugins. With 1.52.1, I have the following binaries installed by the package: > > /usr/bin/grpc_csharp_plugin > /usr/bin/grpc_php_plugin > /usr/bin/grpc_node_plugin > /usr/bin/grpc_python_plugin > /usr/bin/grpc_objective_c_plugin > /usr/bin/grpc_ruby_plugin > /usr/bin/grpc_cpp_plugin > > With 1.52.1-r1, the binaries aren't installed anymore. This breaks code > generation from .proto files. > > Maybe something to do with the "-DgRPC_INSTALL=OFF" cmake argument that was > added in -r1? Yeah, just reverted it as I made a mistake - sorry. But we're in deeper trouble now: ABSL_ENABLE_INSTALL still installs it.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fac39f7470bcbcb959dc586da3b7bb51b6c974c4 commit fac39f7470bcbcb959dc586da3b7bb51b6c974c4 Author: Mark Conway <mark.conway@themobiusproject.com> AuthorDate: 2023-06-26 00:51:01 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-08-21 17:29:13 +0000 net-libs/grpc: version bump to 1.55.1 Closes: https://bugs.gentoo.org/908373 Signed-off-by: Mark Conway <mark.conway@themobiusproject.com> Signed-off-by: Sam James <sam@gentoo.org> net-libs/grpc/Manifest | 2 + net-libs/grpc/grpc-1.55.1.ebuild | 107 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 109 insertions(+) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a5c74e0a36a2dbb1afd8597df55a179bacc45786 commit a5c74e0a36a2dbb1afd8597df55a179bacc45786 Author: Sam James <sam@gentoo.org> AuthorDate: 2023-07-13 12:27:44 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-08-21 17:29:14 +0000 net-libs/grpc: add 1.56.1 Bug: https://bugs.gentoo.org/908373 Signed-off-by: Sam James <sam@gentoo.org> net-libs/grpc/grpc-1.55.1.ebuild | 2 +- net-libs/grpc/grpc-1.56.1.ebuild | 106 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 107 insertions(+), 1 deletion(-)
