Created attachment 861751 [details] media-gfx:kphotoalbum-5.10.0:20230515-193323.log > lib/kpaexif/DatabaseElement.cpp:80:44: error: ‘class Exiv2::Exifdatum’ has no member named ‘toLong’ > 80 | return QVariant { (int)data[m_tag].toLong() }; > | ^~~~~~ > lib/kpaexif/DatabaseElement.cpp:80:53: error: no matching function for call to ‘QVariant::QVariant(<brace-enclosed initializer list>)’ > 80 | return QVariant { (int)data[m_tag].toLong() }; > | ^ ...and so on.
I can't reprodice this ... I have KPA 5.10.0 installed, and I also just re-installed it without a problem. Looks like some problem with exiv2? I have media-gfx/exiv2-0.27.6, the only not masked version?
Yeah sorry for not explaining it better, I was mass-filing exiv2-0.28 failures - this is why this bug is blocking bug 906463, our exiv2-0.28-breakage tracker.
Ah, okay. So we need to patch it for exiv2 0.28. Thanks for the info :-)
Okay. No quick fix. This specific issue can be resolved by using "toInt64" instead of "toLong". But the next build failure to pop up is /home/tobias/tmp/git/kphotoalbum/lib/kpaexif/Database.cpp:323:23: error: 'AutoPtr' is not a member of 'Exiv2::Image' Seems like we'll have to put some work in this ;-) Thanks for pointing out the problem. I'll file an upstream bug to track this and inform you here as soon as we're done with it.
Thanks in advance. For inspiration you can have a look at libkexvi2 fix: https://invent.kde.org/graphics/libkexiv2/-/commit/68c21bba5f73ea6abfdf031139ed085251ef660d
Thanks for the additional info :-) I pushed a new branch tracking this that builds with exiv2 0.28: https://invent.kde.org/graphics/kphotoalbum/-/tree/exiv2-0.28 The new Exiv2::Image::UniquePtr and Exiv2::Image::AutoPtr macro switches could possibly simply be worked around by using "auto". For the "toLong()" thingy we need it though I think. However, this is only a detail. I'll inform you as soon as somebody from the team reviewed this. Either we can add a Gentoo patch making it work with exiv2 0.28, or we simply include this in our next release. Whatever happens first (we're a bit slow with new releases recently ... ;-)
I just merged the patch branch. The changes can be found here: https://invent.kde.org/graphics/kphotoalbum/-/commit/7361e53e743b0fb025e5e4b83ef8a2af4116da95
Created attachment 863582 [details, diff] Patch to make KPA compile with exiv2 0.28 If you're in a hurry (meaning you need it before our next release), here's the patch to make it work :-)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5fcdd88ce2c60819bbd2fe42e11eeab640376d0a commit 5fcdd88ce2c60819bbd2fe42e11eeab640376d0a Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2023-06-08 19:48:08 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2023-06-08 19:48:08 +0000 media-gfx/kphotoalbum: Fix build with >=exiv2-0.28 Thanks-to: Tobias Leupold <tl@stonemx.de> Closes: https://bugs.gentoo.org/906469 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> .../files/kphotoalbum-5.10.0-exiv2-0.28.patch | 147 +++++++++++++++++++++ media-gfx/kphotoalbum/kphotoalbum-5.10.0.ebuild | 2 + 2 files changed, 149 insertions(+)
FYI: I just released KPA 5.11.0, which includes the exiv2 patch :-)
(In reply to Tobias Leupold from comment #10) > FYI: I just released KPA 5.11.0, which includes the exiv2 patch :-) Thanks, hereby bumped!
Nice, thanks for the quick follow-up!
