Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 902201 - dev-java/swt-4.27 adds -Werror flag on its own
Summary: dev-java/swt-4.27 adds -Werror flag on its own
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2023-03-19 21:33 UTC by Agostino Sarubbo
Modified: 2023-03-21 06:07 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,64.71 KB, text/plain)
2023-03-19 21:33 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-03-19 21:33:10 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-java/swt-4.27 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: ci)

NOTE:
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.
Comment 1 Agostino Sarubbo gentoo-dev 2023-03-19 21:33:12 UTC
CC'ing also the author of the commit (f827629c3b99735e623babe93c76624251cd2fd2)
Comment 2 Agostino Sarubbo gentoo-dev 2023-03-19 21:33:13 UTC
Created attachment 858419 [details]
build.log

build log and emerge --info
Comment 3 Larry the Git Cow gentoo-dev 2023-03-21 06:07:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dab82896df0e604b23b16da9cfd359d217f76a85

commit dab82896df0e604b23b16da9cfd359d217f76a85
Author:     Volkmar W. Pogatzki <gentoo@pogatzki.net>
AuthorDate: 2023-03-20 12:14:42 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2023-03-21 06:07:13 +0000

    dev-java/swt: No more CFLAGS += -Werror
    
    Closes: https://bugs.gentoo.org/902201
    Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
    Closes: https://github.com/gentoo/gentoo/pull/30259
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 .../files/swt-4.27-as-needed-and-flag-fixes.patch  | 39 +++++++++++-----------
 1 file changed, 20 insertions(+), 19 deletions(-)