When I had suggested NOCOLOR back in November, I was not aware that there is a quasi-standard for this: https://no-color.org/ says: "Command-line software which adds ANSI color to its output by default should check for a NO_COLOR environment variable that, when present and not an empty string (regardless of its value), prevents the addition of ANSI color." Since this is a relatively new feature, presumably a global s/NOCOLOR/NO_COLOR/g could be done, without keeping the old variable for backwards compatibility.
Created attachment 855078 [details, diff] scan: Replace NOCOLOR by NO_COLOR
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/proj/pkgcore/pkgcheck.git/commit/?id=b9b5dc7dd1da1a659bc6987665e16c904d0271a9 commit b9b5dc7dd1da1a659bc6987665e16c904d0271a9 Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2023-02-28 09:05:21 +0000 Commit: Arthur Zamarin <arthurzam@gentoo.org> CommitDate: 2023-03-01 18:36:10 +0000 scan: Replace NOCOLOR by NO_COLOR NO_COLOR is an informal standard that is followed by many programs, see https://no-color.org/. Signed-off-by: Ulrich Müller <ulm@gentoo.org> Closes: https://bugs.gentoo.org/898230 Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org> src/pkgcheck/scripts/pkgcheck_scan.py | 2 +- tests/scripts/test_pkgcheck_scan.py | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-)
