Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 89683 - patch to improve make.conf marking, and add an option to install a precompiled kernel
Summary: patch to improve make.conf marking, and add an option to install a precompile...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Release Media
Classification: Unclassified
Component: Installer (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux Installer
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-19 10:24 UTC by Marko Djukic
Modified: 2006-03-24 13:46 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to improve the marking of what was added by the GLI in the make.conf (GLIArchitectureTemplate.py.patch,1.72 KB, patch)
2005-04-19 10:25 UTC, Marko Djukic
Details | Diff
expand the previous patch to include also addition for installing a precompiled kernel (gli.patch,9.09 KB, patch)
2005-04-21 10:46 UTC, Marko Djukic
Details | Diff
Updated patch to use emerge -K (gli.patch,9.34 KB, patch)
2005-04-26 07:29 UTC, Marko Djukic
Details | Diff
more additions (gli.patch,17.99 KB, patch)
2005-04-27 05:44 UTC, Marko Djukic
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marko Djukic 2005-04-19 10:24:17 UTC
this gives a more readable formatting to the final make.conf file by
adding a space and then just a single "GLI additions" line as a
comment before all the lines (not for each one), and a final comment
at the end.

i tweaked the logic to identify the comments by checking for COMMENT
in the key. i couldn't figure out why having that in the value would
make sense (especially as then there would be no value to actually
print as the comment). also not sure what the "##comment##" format is
used for so i made it the same logic.

also i added a SPACER check which can add blank lines to the
make.conf, although not really necessary, just prettiness.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Marko Djukic 2005-04-19 10:25:11 UTC
Created attachment 56686 [details, diff]
patch to improve the marking of what was added by the GLI in the make.conf
Comment 2 Marko Djukic 2005-04-21 10:43:00 UTC
This integrates the previous patch with the additional code to allow a precompiled kernel to be installed.

The installer profile needs a section similar to:
    <kernel-compiled>
        http://example.com/kernel/compiled/kernel-2.6.11-gentoo-r5.tgz
    </kernel-compiled>

The tarball should contain whatever is required for the precompiled kernel to be installed in the target machine, eg. boot/kernel, boot/initrd and any lib/modules/2.6.11-gentoo-r5/*

This step is then invoked with "install_kernel".

Comment 3 Marko Djukic 2005-04-21 10:46:43 UTC
Created attachment 56855 [details, diff]
expand the previous patch to include also addition for installing a precompiled kernel
Comment 4 Andrew Gaffney (RETIRED) gentoo-dev 2005-04-21 14:33:03 UTC
The custom pre-compiled kernel tarball should be a quickpkg'd binary. You can use my 'mkvardb' script in installer/src/misc and then 'quickpkg' it. That way, the new install can track the files and have the virtual/alsa dependency PROVIDE'd. It can be handled the same way the livecd-kernel stuff is now. The tarball can be downloaded and copied to /mnt/gentoo/usr/portage/packages/All and then 'emerge -K'd into place.
Comment 5 Marko Djukic 2005-04-26 07:29:00 UTC
Created attachment 57287 [details, diff]
Updated patch to use emerge -K

This patch now implements the pkg install of a precompiled kernel. It also
introduces a different way to specify the kernels to be installed using the
following xml:
<kernels>
  <kernel type="precompiled">
      mykernel-2.6
  </kernel>
  <kernel type="emerge">
    =gentoo-sources-2.6.7-r19
  </kernel>
</kernels>
This would install both a precompiled kernel package and a kernel from an
emerge of the gentoo sources.
Comment 6 Marko Djukic 2005-04-27 05:44:02 UTC
Created attachment 57383 [details, diff]
more additions

Expands more on the previous patches
- Ability to specify files to go into /etc/portage/*, eg.:
    <etc-portage>
	<file name="package.use">
	    sys-libs/glibc userlocales
	    dev-php/mod_php -ldap gd imap mysql -pdflib apache2 -qt -spell
-truetype -java
	    dev-php/php -ldap gd imap mysql -pdflib -qt -truetype -java
	</file>
	<file name="package.keywords">
	    =net-mail/perdition-1.15 ~x86
	</file>
- Allow xml parsing to yank in the whole contents of the node data (ie. remove
the string.strip() which was concat-ing all the lines into one single line)
- Comments - can they be more readable with some aligning?#
- Allow _edit_config to create a file if it doesn't exist (set to True by
default)
Comment 7 Preston Cody (RETIRED) gentoo-dev 2005-05-09 21:16:54 UTC
most of the patch is now in CVS.  parts not included are the install_kernel step and precompiled kernels.  sorry but I don't think now is the time for that type of functionality.
Comment 8 Jeffrey Forman (RETIRED) gentoo-dev 2006-03-24 13:46:27 UTC
Moving to Release Media/Installer.