Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 896200 - mate-extra/mate-sensors-applet-1.26.0 fails to compile (MUSL-CLANG-SYSTEM): i2c-proc-plugin.c:148:31: error: call to undeclared function setlocale; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
Summary: mate-extra/mate-sensors-applet-1.26.0 fails to compile (MUSL-CLANG-SYSTEM): i...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo MATE Desktop
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: c99-porting
  Show dependency tree
 
Reported: 2023-02-24 09:11 UTC by Agostino Sarubbo
Modified: 2023-05-09 17:51 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (build.log,112.82 KB, text/plain)
2023-02-24 09:11 UTC, Agostino Sarubbo 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-02-24 09:11:52 UTC 
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: mate-extra/mate-sensors-applet-1.26.0 fails to compile (MUSL-CLANG-SYSTEM).
Discovered on: amd64 (internal ref: tinderbox_musl)

NOTE:
(MUSL-CLANG-SYSTEM) in the summary means that bug was found on a machine that runs MUSL libc + clang16 but this bug MAY or MAY NOT BE related to musl/clang16.
Comment 1 Agostino Sarubbo gentoo-dev 2023-02-24 09:11:55 UTC 
Created attachment 854282 [details]
build.log

build log and emerge --info
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-05-05 04:49:16 UTC 
listout: can you finish off the upstream PR please? thanks
Comment 3 listout 2023-05-05 05:29:03 UTC 
Yes. I don't have access to a musl box right now. Hence the delay.
Comment 4 listout 2023-05-05 05:40:48 UTC 
(In reply to listout from comment #3)
> Yes. I don't have access to a musl box right now. Hence the delay.

I've pushed the changes the maintainer/s asked for (removing the include guards). Let's see.
Comment 5 listout 2023-05-08 17:14:21 UTC 
(In reply to Sam James from comment #2)
> listout: can you finish off the upstream PR please? thanks

That PR is now merged
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-05-08 17:19:43 UTC 
(In reply to listout from comment #5)
> (In reply to Sam James from comment #2)
> > listout: can you finish off the upstream PR please? thanks
> 
> That PR is now merged

PR to pull it in now?
Comment 7 listout 2023-05-08 17:31:59 UTC 
Done
Comment 8 Larry the Git Cow gentoo-dev 2023-05-09 17:51:16 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2e2f143876b32fbaeae7e1d59e79cbe340612c76

commit 2e2f143876b32fbaeae7e1d59e79cbe340612c76
Author:     Brahmajit Das <brahmajit.xyz@gmail.com>
AuthorDate: 2023-05-08 18:09:23 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-05-09 17:50:54 +0000

    mate-extra/mate-sensors-applet: fix undeclared function setlocale
    
    Closes: https://bugs.gentoo.org/896200
    Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/30937
    Signed-off-by: Sam James <sam@gentoo.org>

 ...lang-16-fix-undeclared-function-setlocale.patch | 130 +++++++++++++++++++++
 .../mate-sensors-applet-1.26.0-r1.ebuild           |  65 +++++++++++
 2 files changed, 195 insertions(+)