Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 89577 - sylpheed-claws smtps problem with gmail.com
Summary: sylpheed-claws smtps problem with gmail.com
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Marius Mauch (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-18 13:41 UTC by ArYiX
Modified: 2005-05-04 16:21 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch_smtps_with_gmail (patch_smtps_with_gmail.diff,875 bytes, patch)
2005-04-18 13:43 UTC, ArYiX
Details | Diff
socket complement for previous patch (fix_socket_gmail_smtps.diff,3.16 KB, patch)
2005-04-22 02:18 UTC, ArYiX
Details | Diff
full patch gmail smtps accept EOF after QUIT is ok (full_patch_smtps_gmail_v2.diff,3.01 KB, patch)
2005-04-25 03:57 UTC, ArYiX
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ArYiX 2005-04-18 13:41:15 UTC
[17:49:33] SMTP< 250 2.1.5 OK
[17:49:33] SMTP> DATA
[17:49:34] SMTP< 354 Go ahead
[17:49:34] SMTP> . (EOM)
[17:49:34] SMTP< 250 2.0.0 OK 1113856702
[17:49:34] SMTP> QUIT
** Error occurred while sending the message.


this problem has been fixed in CVS tree of sylpheed-claws with:

--- send_message.c.orig 2004-06-08 10:55:38.000000000 +0000
+++ send_message.c      2005-04-18 17:13:21.000000000 +0000
@@ -1,6 +1,6 @@
 /*
  * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2003 Hiroyuki Yamamoto
+ * Copyright (C) 1999-2005 Hiroyuki Yamamoto
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -412,6 +412,11 @@
                        ac_prefs->tmp_smtp_pass = NULL;
                }
                ret = -1;
+       } else if (session->state == SESSION_EOF &&
+                  SMTP_SESSION(session)->state == SMTP_QUIT) {
+               /* consider EOF right after QUIT successful */
+               log_warning("%s\n", _("Connection closed by the remote host."));
+               ret = 0;
        } else if (session->state == SESSION_ERROR ||
                   session->state == SESSION_EOF ||
                   session->state == SESSION_TIMEOUT ||


bye bye
Comment 2 ArYiX 2005-04-22 02:18:56 UTC
Created attachment 56909 [details, diff]
socket complement for previous patch

the two separates patches are needed for do smtps with gmail,.....
Comment 3 Marius Mauch (RETIRED) gentoo-dev 2005-04-23 06:15:27 UTC
Hmm, the resolv.conf patch isn't present in Colins patch, any reason why you included that one too?
Comment 4 ArYiX 2005-04-23 14:22:23 UTC
hmm, not really, here is the patch....

2005-03-30 [colin]	1.9.6cvs13

	* src/common/socket.c
		Force the glibc to read resolv.conf again when
		it has changed. Should fix issues when changing
		networks on a laptop and not restarting sylpheed.
		(I'll check tomorrow if a similar hack has to be
		done if the route changes).

ok, i working, to remove this, not needed for patch smtps.

the patch must be objetive & fix one problem only?
in this case you have a reason
Comment 5 ArYiX 2005-04-25 03:57:41 UTC
Created attachment 57158 [details, diff]
full patch gmail smtps accept EOF after QUIT is ok

full patch for do smtps, to gmail without other changes
Comment 6 Rick Sheppard 2005-04-26 17:52:35 UTC
this bug also affects the regular sylpheed. The 'stable' branch. aka non-claws.
Comment 7 Marius Mauch (RETIRED) gentoo-dev 2005-05-04 16:21:49 UTC
1.0.5 should fix this for claws and should be out on Monday, so I'm not going to bother with doing a revbump with this patch.
Don't know about sylpheed although I assume that there will be a 1.0.5 for it too.