In https://github.com/trofi/nix-guix-gentoo/issues/29 Gooberpatrol66 noticed that `CFLAGS="-flto" CXXFLAGS="-flto" emerge -v1 app-text/mdbook-linkcheck` fails the build on `openssl-sys` crate as: note: /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-text/mdbook-linkcheck-0.7.7/work/mdbook-linkcheck-0.7.7/target/release/deps/libopenssl_sys-41acaa7dec2f671 e.rlib(x86_64cpuid.o):(.init+0x1): undefined reference to `OPENSSL_cpuid_setup' The workaround of using `filter-lto` does work https://github.com/trofi/nix-guix-gentoo/commit/c95caa8da8dbeb38eb5fc58bd1529ceb73d04d9d but I don't think every downstream ebuild should carry the workaround. On top of that filter-lto is probably too conservative: for clang toolchains I would expect at least some interoperability between rust and clang bytecode. Filtering should probably happen based on $CC/$CXX toolchain type and not unconditionally. cargo.eclass sounds like a natural place to add a hack to disable -flto flags if it can't handle the mix of gcc's LTO bytecode, llvm's (byte?)code and system linker. And later extend it to cover at least some of simpler cases. List of current seemingly relevant workarounds: $ fgrep filter-lto $(git grep -Pl 'inherit.* cargo') app-emulation/ruffle/ruffle-0_p20230125.ebuild: filter-lto # does not play well with C code in crates app-emulation/ruffle/ruffle-9999.ebuild: filter-lto # does not play well with C code in crates app-misc/weggli/weggli-0.2.4.ebuild: filter-lto app-shells/starship/starship-1.10.3-r1.ebuild: filter-lto app-shells/starship/starship-1.11.0-r1.ebuild: filter-lto app-shells/starship/starship-1.12.0.ebuild: filter-lto dev-util/maturin/maturin-0.14.10.ebuild: filter-lto # undefined references with ring crate dev-util/maturin/maturin-0.14.12.ebuild: filter-lto # undefined references with ring crate media-gfx/oxipng/oxipng-6.0.0.ebuild: filter-lto # 860063 file format not recognized with cloudflare-zlib-sys media-gfx/oxipng/oxipng-6.0.1.ebuild: filter-lto # 860063 file format not recognized with cloudflare-zlib-sys media-gfx/oxipng/oxipng-7.0.0.ebuild: filter-lto # 860063 file format not recognized with cloudflare-zlib-sys media-gfx/oxipng/oxipng-8.0.0.ebuild: filter-lto # 860063 file format not recognized with cloudflare-zlib-sys media-libs/cubeb/cubeb-0.2_p20220922.ebuild: filter-lto net-news/newsboat/newsboat-2.28.ebuild: filter-lto # bug #877657 net-news/newsboat/newsboat-2.29.ebuild: filter-lto # bug #877657 net-news/newsboat/newsboat-2.30.1.ebuild: filter-lto # bug #877657 # emerge --info Portage 3.0.44 (python 3.10.10-final-0, default/linux/amd64/17.1, gcc-12, glibc-2.36-r7, 6.1.10 x86_64) ================================================================= System uname: Linux-6.1.10-x86_64-AMD_Ryzen_9_5950X_16-Core_Processor-with-glibc2.36 KiB Mem: 131862464 total, 51256996 free KiB Swap: 197792252 total, 197792252 free Timestamp of repository gentoo: Wed, 08 Feb 2023 22:00:01 +0000 Head commit of repository gentoo: 7e549adf29f028b9fc285103d119991bf2ea8900 sh bash 5.2_p15-r1 ld GNU ld (Gentoo 2.40 p1) 2.40 ccache version 4.7.4 [disabled] app-misc/pax-utils: 1.3.7::gentoo app-shells/bash: 5.2_p15-r1::gentoo dev-lang/perl: 5.36.0-r2::gentoo dev-lang/python: 3.10.10::gentoo, 3.11.2::gentoo dev-lang/rust: 1.67.0::gentoo dev-util/ccache: 4.7.4::gentoo dev-util/cmake: 3.25.2::gentoo dev-util/meson: 1.0.0::gentoo sys-apps/baselayout: 2.13-r1::gentoo sys-apps/sandbox: 2.30-r1::gentoo sys-apps/systemd: 252.5::gentoo sys-devel/autoconf: 2.71-r5::gentoo sys-devel/automake: 1.16.5::gentoo sys-devel/binutils: 2.40::gentoo sys-devel/binutils-config: 5.5::gentoo sys-devel/gcc: 12.2.1_p20230121-r1::gentoo sys-devel/gcc-config: 2.10::gentoo sys-devel/libtool: 2.4.7-r1::gentoo sys-devel/llvm: 15.0.7::gentoo sys-devel/make: 4.4::gentoo sys-kernel/linux-headers: 6.1::gentoo (virtual/os-headers) sys-libs/glibc: 2.36-r7::gentoo Repositories: gentoo location: /bound/portage sync-type: rsync sync-uri: rsync://rsync.gentoo.org/gentoo-portage priority: -1000 volatile: True sync-rsync-verify-metamanifest: yes sync-rsync-verify-max-age: 24 sync-rsync-extra-opts: sync-rsync-verify-jobs: 1 crossdev location: /co masters: gentoo volatile: True slyfox location: /bound/slyfox-gentoo masters: gentoo priority: 0 volatile: True nix-guix location: /bound/nix-guix-gentoo masters: gentoo priority: 1 volatile: True ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="@FREE" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-O2 -pipe -fdiagnostics-show-option -frecord-gcc-switches" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/sandbox.d /etc/terminfo" CXXFLAGS="-O2 -pipe" DISTDIR="/bound/distfiles" ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg-live config-protect-if-modified distlocks ebuild-locks fail-clean fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="http://distfiles.gentoo.org" LANG="C.UTF8" LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu" LEX="flex" MAKEOPTS="-j17 -l17" PKGDIR="/var/cache/binpkgs" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/dev/shm" SHELL="/bin/bash" USE="X acl amd64 bzip2 cli crypt dri fortran gdbm harfbuzz iconv ipv6 libglvnd libtirpc minizip multilib ncurses nls nptl opengl openmp pam pcre readline seccomp split-usr ssl systemd test-rust unicode xattr zlib" ABI_X86="64" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_10" PYTHON_TARGETS="python3_10" RUBY_TARGETS="ruby31" USERLAND="GNU" VIDEO_CARDS="amdgpu fbdev intel nouveau radeon radeonsi vesa dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EMERGE_DEFAULT_OPTS, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
kind of agree, we already filter out -flto in some cases.
I have a number of improvements queued for cargo.eclass https://github.com/gentoo/gentoo/compare/master...gyakovlev:gentoo:cargo-eclass-improvements this one queued as well now, since most cases are covered we have time.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dc51935f7aae5f89d1ffecabef322680979952b8 commit dc51935f7aae5f89d1ffecabef322680979952b8 Author: Georgy Yakovlev <gyakovlev@gentoo.org> AuthorDate: 2023-02-09 00:49:47 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-07-12 06:24:42 +0000 cargo.eclass: filter out lto flags for C/CXX compilers we do it in src_compile to avoid excessive flag stripping in projects using cargo.eclass just to fetch crates. Bug: https://bugs.gentoo.org/903908 Closes: https://bugs.gentoo.org/893658 Closes: https://bugs.gentoo.org/910220 Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org> Signed-off-by: Sam James <sam@gentoo.org> eclass/cargo.eclass | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
