Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 893212 - dev-python/tavern: removal
Summary: dev-python/tavern: removal
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Deadline: 2023-03-06
Assignee: Matt Jolly
URL:
Whiteboard:
Keywords: PMASKED
Depends on:
Blocks: 884091
  Show dependency tree
 
Reported: 2023-02-04 12:33 UTC by Arthur Zamarin
Modified: 2023-02-20 18:06 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2023-02-04 12:33:47 UTC
pytest plugin, which breaks a lot of python_test of other ebuilds if installed unless disabled. The package itself is hard to maintain. No reverse dependencies.
Comment 1 Larry the Git Cow gentoo-dev 2023-02-04 12:36:27 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7b1794377af3b75d0a500d046dcb40960a79da19

commit 7b1794377af3b75d0a500d046dcb40960a79da19
Author:     Arthur Zamarin <arthurzam@gentoo.org>
AuthorDate: 2023-02-04 12:35:53 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2023-02-04 12:35:53 +0000

    dev-python/tavern: last-rite
    
    Bug: https://bugs.gentoo.org/893212
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 profiles/package.mask | 7 +++++++
 1 file changed, 7 insertions(+)
Comment 2 Matt Jolly gentoo-dev 2023-02-16 10:27:58 UTC
As discussed on IRC I don't have a particular objection to last-riting this package, but please check in with the maintainer of sabnzbd; they may want the API testing this enables.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-02-17 07:53:25 UTC
I suppose it makes sense to keep it for the sake of that testing.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-02-17 08:20:14 UTC
That said, all API tests in sab* are failing for me, so I need to look into it more.
Comment 5 Matt Jolly gentoo-dev 2023-02-20 04:10:08 UTC
(In reply to Michał Górny from comment #4)
> That said, all API tests in sab* are failing for me, so I need to look into
> it more.

I swear they _were_ working when I added tavern & tavalidate. :)
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-02-20 06:58:29 UTC
Ok, looks like other pytest plugins were interfering.  I still need to test if they still pass with tavern-2.
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-02-20 14:32:30 UTC
So sabnzbd clearly doesn't work with tavern-2.  Also, upstream requirements.txt suggest that tavalidate also does not, although from my quick testing both of tavalidate tests pass and there is no bug report about such incompatibility.  Nevertheless, if this is really the case then this is probably doomed, as tavalidate didn't see any commits since 2020.
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-02-20 18:06:09 UTC
Fixed savnzbd tests to work with tavern-2 and unmasked the set.