Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 889036 - sys-kernel/gentoo-sources sys-kernel/zen-sources sys-kernel/git-sources have incorrect LICENSE
Summary: sys-kernel/gentoo-sources sys-kernel/zen-sources sys-kernel/git-sources have ...
Status: RESOLVED DUPLICATE of bug 693288
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Other
: Normal normal (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-31 06:46 UTC by ganooslashlinus
Modified: 2022-12-31 12:56 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ganooslashlinus 2022-12-31 06:46:56 UTC
LICENSE="GPL-2" is not correct, as despite all the claims that it doesn't, Linux contains proprietary software.


See below for a non-exhaustive listing of proprietary software that I have found thus far:

drivers/net/appletalk/cops_ffdrv.h
drivers/net/appletalk/cops_ltdrv.h:
 *      The firmware this driver downloads into the Localtalk card is a
 *      separate program and is not GPL'd source code, even though the Linux
 *      side driver and the routine that loads this data into the card are.
 *      
 *      It is taken from the COPS SDK and is under the following license
 *
 *      This material is licensed to you strictly for use in conjunction with
 *      the use of COPS LocalTalk adapters.
 *      There is no charge for this SDK. And no waranty express or implied
 *      about its fitness for any purpose. However, we will cheerefully
 *      refund every penny you paid for this SDK...
 *      Regards,
 *
 *      Thomas F. Divine
 *      Chief Scientist


arch/powerpc/platforms/8xx/micropatch.c:
 * Microcode patches for the CPM as supplied by Motorola.
 * This is the one for IIC/SPI.  There is a newer one that
 * also relocates SMC2, but this would require additional changes
 * to uart.c, so I am holding off on that for a moment.

Although the identifier notes GPLv2-only, I can't find any corresponding source code, nor a written offer for such, so that's not the license.


I've also seen certain tables in the below that look like they could contain software, with no source code available, but there is the possibility that such is all pure data and/or magic register values: 
drivers/net/ethernet/realtek/r8169_main.c
drivers/net/usb/r8152.c          
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192c.c
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723a.c
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c
drivers/net/wireless/realtek/rtw88/rtw8821c.c
drivers/net/wireless/realtek/rtw88/rtw8822b.c
drivers/net/wireless/realtek/rtw88/rtw8723d.c
drivers/net/wireless/realtek/rtw89/rtw8852a.c
drivers/net/phy/mscc/mscc_main.c


I've checked that the above applies to gentoo-sources-6.1.1, git-sources-6.2_rc1, zen-sources-6.0.12, but it probably applies to most, if not all versions of Linux in tree.



In case anyone wants to claim that drivers/net/appletalk/cops_ffdrv.h, drivers/net/appletalk/cops_ltdrv.h and arch/powerpc/platforms/8xx/micropatch.c aren't software:
./cpu_rec.py ffdrv_code ltdrv_code patch_2*:
ffdrv_code                                                                 full(0x175f)   None                               chunk(0x400;2)      Z80       
ltdrv_code                                                                 full(0x9c5)    Z80                                chunk(0x400;4)      Z80       
patch_2000                                                                 full(0x1d0)    6502                               chunk(0xc0;3)       6502      
patch_2000_2                                                               full(0x500)    6502                               chunk(0x300;3)      6502      
patch_2000_3 - invalid about as too few bytes
patch_2000_4                                                               full(0x348)    None                               chunk(0x1c0;7)      6502      
patch_2e00                                                                 full(0x40)     6502                               chunk(0x40;1)       6502      
patch_2f00                                                                 full(0x74)     6502                               chunk(0x40;1)       6502      
patch_2f00_2                                                               full(0x100)    6502                               chunk(0x100;4)      6502      
patch_2f00_3 - invalid about as too few bytes
patch_2f00_4                                                               full(0xd4)     6502                               chunk(0xc0;3)       6502


You would think the Communications Processor Module wouldn't contain a 6502 (as Motorola), but it looks like it does.



Therefore, it should be: LICENSE="GPL-2 no-source-code COPS" (the COPS SDK "license" needs to be added).
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-12-31 12:19:24 UTC
I'll CC licenses@ as there's some history here wrt the appletalk stuff at least, IIRC.
Comment 2 Ulrich Müller gentoo-dev 2022-12-31 12:56:18 UTC
This should be reported upstream and fixed there. Presumably, the appletalk firmware should be moved to the linux-firmware package.

Please continue discussion in bug 693288.

*** This bug has been marked as a duplicate of bug 693288 ***