Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 888867 - dev-util/rocprofiler-5.1.3-r1 adds -Werror flag on its own
Summary: dev-util/rocprofiler-5.1.3-r1 adds -Werror flag on its own
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Science Related Packages
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2022-12-29 12:50 UTC by Agostino Sarubbo
Modified: 2023-01-31 14:18 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,96.45 KB, text/plain)
2022-12-29 12:50 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-29 12:50:27 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-util/rocprofiler-5.1.3-r1 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: dash_tinderbox)

NOTE:
(DASH-SYSTEM) in the summary means that the bug was found on a machine that runs /bin/sh as dash but this bug MAY or MAY NOT BE related to dash.
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-29 12:50:29 UTC
Created attachment 845645 [details]
build.log

build log and emerge --info
Comment 2 Larry the Git Cow gentoo-dev 2023-01-31 14:18:42 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=acf7743519df9e0592827326467127316aaa1439

commit acf7743519df9e0592827326467127316aaa1439
Author:     Yiyang Wu <xgreenlandforwyy@gmail.com>
AuthorDate: 2023-01-27 15:11:14 +0000
Commit:     Benda Xu <heroxbd@gentoo.org>
CommitDate: 2023-01-31 14:18:27 +0000

    dev-util/rocprofiler: strip -Werror
    
    Closes: https://bugs.gentoo.org/888867
    Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
    Signed-off-by: Benda Xu <heroxbd@gentoo.org>

 .../rocprofiler/files/rocprofiler-5.1.3-remove-Werror.patch  | 12 ++++++++++++
 dev-util/rocprofiler/rocprofiler-5.1.3-r1.ebuild             |  3 ++-
 2 files changed, 14 insertions(+), 1 deletion(-)