Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 887897 - [guru] net-misc/tinyssh-20230101 overwrites user's optimization (-O*)
Summary: [guru] net-misc/tinyssh-20230101 overwrites user's optimization (-O*)
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Haelwenn (lanodan) Monnier
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: qa-guru
  Show dependency tree
 
Reported: 2022-12-22 08:34 UTC by Agostino Sarubbo
Modified: 2024-02-28 07:07 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,55.05 KB, text/plain)
2022-12-22 08:34 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-22 08:34:45 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-misc/tinyssh-20220801 overwrites user's optimization (-O*).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting
man gcc says:
"If you use multiple -O options, with or without level numbers, the last such option is the one that is effective".

So, since the build system adds -O* after -O* provided by my CFLAGS/CXXFLAGS means that it is overwritten and unless there are known issues with -O* configured by the user, the build system should not overwrite -O*.
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-22 08:34:47 UTC
Created attachment 844671 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2023-01-04 14:47:01 UTC
guru_ci has reproduced this issue with version 20230101 - Updating summary.
Comment 3 Larry the Git Cow gentoo-dev 2024-02-28 07:07:03 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2b4ac4bd6ae654d14218883ac7a298cd1d2d5b42

commit 2b4ac4bd6ae654d14218883ac7a298cd1d2d5b42
Author:     Haelwenn (lanodan) Monnier <contact@hacktivis.me>
AuthorDate: 2024-02-02 17:12:53 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-02-28 07:01:47 +0000

    net-misc/tinyssh: respect user CFLAGS
    
    Closes: https://bugs.gentoo.org/887897
    Signed-off-by: Haelwenn (lanodan) Monnier <contact@hacktivis.me>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 net-misc/tinyssh/files/tinyssh-20240101_conf_cflags.patch | 10 ++++++++++
 net-misc/tinyssh/tinyssh-20240101.ebuild                  |  7 ++++---
 2 files changed, 14 insertions(+), 3 deletions(-)