Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 887893 - [guru] net-misc/moonlight-3.1.4 overwrites user's optimization (-O*)
Summary: [guru] net-misc/moonlight-3.1.4 overwrites user's optimization (-O*)
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Andrew Athalye
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qa-guru
  Show dependency tree
 
Reported: 2022-12-22 08:33 UTC by Agostino Sarubbo
Modified: 2023-02-13 11:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,217.89 KB, text/plain)
2022-12-22 08:33 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-22 08:33:45 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-misc/moonlight-3.1.4 overwrites user's optimization (-O*).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting
man gcc says:
"If you use multiple -O options, with or without level numbers, the last such option is the one that is effective".

So, since the build system adds -O* after -O* provided by my CFLAGS/CXXFLAGS means that it is overwritten and unless there are known issues with -O* configured by the user, the build system should not overwrite -O*.
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-22 08:33:47 UTC
Created attachment 844669 [details]
build.log

build log and emerge --info
Comment 2 Larry the Git Cow gentoo-dev 2023-02-13 11:27:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=77be02e524e9193d385eaa5bb80282ddb30780ec

commit 77be02e524e9193d385eaa5bb80282ddb30780ec
Author:     Joe Kappus <joe@wt.gd>
AuthorDate: 2023-02-10 09:46:03 +0000
Commit:     Joe Kappus <joe@wt.gd>
CommitDate: 2023-02-10 09:50:52 +0000

    net-misc/moonlight: add 4.3.1, drop 3.1.4
    
    Fixed the CFLAGS getting overridden.
    
    Closes: https://bugs.gentoo.org/887891
    Closes: https://bugs.gentoo.org/887893
    Signed-off-by: Joe Kappus <joe@wt.gd>

 net-misc/moonlight/Manifest                        |  2 +-
 .../moonlight/files/4.3.1-respect-cflags.patch     | 53 ++++++++++++++++++++++
 net-misc/moonlight/metadata.xml                    |  3 ++
 ...onlight-3.1.4.ebuild => moonlight-4.3.1.ebuild} |  7 ++-
 4 files changed, 62 insertions(+), 3 deletions(-)