887421 – media-libs/gegl-0.4.40-r1: fails to compile with media-libs/libraw-0.21.0 (error: struct libraw_output_params_t has no member named ‘shot_select')

Bug 887421 - media-libs/gegl-0.4.40-r1: fails to compile with media-libs/libraw-0.21.0 (error: struct libraw_output_params_t has no member named ‘shot_select')

Summary: media-libs/gegl-0.4.40-r1: fails to compile with media-libs/libraw-0.21.0 (er...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	AMD64 Linux

Importance:	Normal normal with 1 vote (vote)
Assignee:	Sergey Torokhov

URL:	https://gitlab.gnome.org/GNOME/gegl/-...
Whiteboard:
Keywords:	PATCH

Duplicates (1):	887819 (view as bug list)
Depends on:
Blocks:	libraw-0.21
	Show dependency tree

Reported:	2022-12-20 12:26 UTC by Gregory DeGough
Modified:	2023-02-07 08:30 UTC (History)
CC List:	15 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
build log (build.log.xz,25.80 KB, application/x-xz) 2022-12-20 12:28 UTC, Gregory DeGough	Details
emerge --info (emerge-info.txt,8.05 KB, text/plain) 2022-12-20 12:28 UTC, Gregory DeGough	Details
proposed patch to raw-load.c (raw-load_c.patch,535 bytes, patch) 2022-12-20 12:31 UTC, Gregory DeGough	Details \| Diff
updated patch to check for libraw version (raw-load_c.patch,600 bytes, patch) 2022-12-20 12:57 UTC, Gregory DeGough	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gregory DeGough 2022-12-20 12:26:43 UTC

emerge fails when building media-libs/gegl-0.4.40-r1 with media-libs/libraw-0.21.0 due to libraw API change

Reproducible: Always

Steps to Reproduce:
1. emerge media-libs/gegl-0.4.40-r1 with media-libs/libraw-0.21.0 merged
2.
3.

Comment 1 Gregory DeGough 2022-12-20 12:28:11 UTC

Created attachment 844107 [details]
build log

Comment 2 Gregory DeGough 2022-12-20 12:28:43 UTC

Created attachment 844109 [details]
emerge --info

Comment 3 Gregory DeGough 2022-12-20 12:31:23 UTC

Created attachment 844111 [details, diff]
proposed patch to raw-load.c

attached patch to raw-load.c that allows build to complete

Comment 4 Sam James archtester

2022-12-20 12:37:17 UTC

Patch will need a tiny adjustment to add ifdef for libraw version before applying

Comment 5 Gregory DeGough 2022-12-20 12:57:39 UTC

Created attachment 844121 [details, diff]
updated patch to check for libraw version

modified patch: added check for libraw version

Comment 6 Harris Landgarten 2022-12-20 18:06:17 UTC

Same here

Comment 7 Georgy Yakovlev archtester

2022-12-21 04:54:08 UTC

confirmed and updated patch works

Comment 8 Brandon Penglase 2022-12-21 21:31:53 UTC

I can also confirm that the updated patch allowed a clean compile.

Comment 9 Larry the Git Cow gentoo-dev

2022-12-21 23:52:10 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e37f1398f63db9f2a6fe4133599a7169f6780e38

commit e37f1398f63db9f2a6fe4133599a7169f6780e38
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-12-21 23:47:22 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-12-21 23:52:00 +0000

    media-libs/gegl: fix build w/ libraw-0.21
    
    Closes: https://bugs.gentoo.org/887421
    Signed-off-by: Sam James <sam@gentoo.org>

 .../gegl/files/gegl-0.4.40-libraw-0.21.patch       | 26 ++++++++++++++++++++++
 media-libs/gegl/gegl-0.4.40-r1.ebuild              |  1 +
 2 files changed, 27 insertions(+)

Comment 10 Sergey Torokhov 2022-12-22 00:24:33 UTC

Sam James,
thank you for fix the ebuild

Comment 11 Sam James archtester

2022-12-22 02:16:54 UTC

*** Bug 887819 has been marked as a duplicate of this bug. ***

Comment 12 jospezial 2023-02-06 07:23:55 UTC

The patch is now in gegl master branch. Please remove it from the live ebuild.

Comment 13 Sam James archtester

2023-02-07 04:25:49 UTC

(In reply to jospezial from comment #12)
> The patch is now in gegl master branch. Please remove it from the live
> ebuild.

e37f1398f63db9f2a6fe4133599a7169f6780e38 didn't add it to the live ebuild and I don't see it in the live ebuild now either:

$ grep -rsin libraw-0.21
gegl-0.4.40-r1.ebuild:81:       "${FILESDIR}"/${PN}-0.4.40-libraw-0.21.patch

Comment 14 jospezial 2023-02-07 08:30:29 UTC

(In reply to Sam James from comment #13)
> (In reply to jospezial from comment #12)
> > The patch is now in gegl master branch. Please remove it from the live
> > ebuild.
> 
> e37f1398f63db9f2a6fe4133599a7169f6780e38 didn't add it to the live ebuild
> and I don't see it in the live ebuild now either:
> 
> $ grep -rsin libraw-0.21
> gegl-0.4.40-r1.ebuild:81:       "${FILESDIR}"/${PN}-0.4.40-libraw-0.21.patch

Sorry,nevermind. I had it as local patch.
Called __helpers_die 'patch -p1  failed with /etc/portage/patches/media-libs/gegl/libraw.patch'