Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 887383 - dev-util/hip-5.3.3-r1 adds -Werror flag on its own
Summary: dev-util/hip-5.3.3-r1 adds -Werror flag on its own
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Science Related Packages
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2022-12-20 10:21 UTC by Agostino Sarubbo
Modified: 2023-01-31 13:32 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,431.38 KB, text/plain)
2022-12-20 10:21 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-20 10:21:31 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-util/hip-5.3.3 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: ci)

NOTE:
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-20 10:21:33 UTC
Created attachment 843999 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2023-01-21 06:49:08 UTC
ci has reproduced this issue with version 5.3.3-r1 - Updating summary.
Comment 3 Larry the Git Cow gentoo-dev 2023-01-31 13:32:22 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=02e622b72fd4770f699859a7b6433ea8a92c648a

commit 02e622b72fd4770f699859a7b6433ea8a92c648a
Author:     Yiyang Wu <xgreenlandforwyy@gmail.com>
AuthorDate: 2023-01-25 04:12:24 +0000
Commit:     Benda Xu <heroxbd@gentoo.org>
CommitDate: 2023-01-31 13:31:33 +0000

    dev-util/hip: remove -Werror added by src/CMakeLists.txt
    
    Closes: https://bugs.gentoo.org/887383
    Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
    Signed-off-by: Benda Xu <heroxbd@gentoo.org>

 dev-util/hip/files/hip-5.3.3-disable-Werror.patch | 16 ++++++++++++++++
 dev-util/hip/hip-5.3.3-r2.ebuild                  |  1 +
 2 files changed, 17 insertions(+)