Bug 886609 – sci-visualization/xd3d-8.3.1-r2 fails to compile (CLANG-STRICTER-SYSTEM): x11device.c:371:2: error: call to undeclared function x11ColormapRVB_; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Agostino Sarubbo 2022-12-18 10:15:40 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-visualization/xd3d-8.3.1-r2 fails to compile (CLANG-STRICTER-SYSTEM).
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting

[Comment 1 Agostino Sarubbo 2022-12-18 10:15:43 UTC]

Created attachment 843363 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2022-12-18 10:15:44 UTC]

Error(s) that match a know pattern in addition to what has been reported in the summary:


f951: Error: ‘-Werror=incompatible-function-pointer-types’: no option ‘-Wincompatible-function-pointer-types’; did you mean ‘-Wincompatible-pointer-types’?
x11device.c:371:2: error: call to undeclared function 'x11ColormapRVB_'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]

[Comment 3 Larry the Git Cow 2025-03-20 00:00:12 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d47942f50ef2572f697f39802021f1e87ef60848

commit d47942f50ef2572f697f39802021f1e87ef60848
Author:     NHOrus <[e-mail]>
AuthorDate: 2025-03-15 16:09:10 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2025-03-19 23:59:10 +0000

    sci-visualization/xd3d: Fix build failures with GCC-15
    
    By slapping -std=gnu17 on it. And fortran option to remove underscore
    insertion in function names.
    Patched relevant files to remove function name defines that fixed name
    incompatibility (due to underscores) but also caused implicit declaration
    errors.
    Re-wrote makefiles - they were written like the author was lacking tab
    key and worked around that. Now it finally stops on error, and not when
    next job fails with bad dependencies.
    Found and changed homepage to new URL.
    Was unable to remove `which` - how do you do that in C shell? It's not
    POSIX, lacks `command` build-in.
    
    Closes: https://bugs.gentoo.org/944746
    Closes: https://bugs.gentoo.org/886609
    Closes: https://bugs.gentoo.org/875236
    Signed-off-by: NHOrus <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/41093
    Signed-off-by: Sam James <[e-mail]>

 sci-visualization/xd3d/files/xd3d-8.3.1-c99.patch  | 464 +++++++++++++++++++++
 .../xd3d/files/xd3d-8.3.1-sane-makefiles.patch     | 219 ++++++++++
 sci-visualization/xd3d/xd3d-8.3.1-r3.ebuild        |  67 +++
 3 files changed, 750 insertions(+)