886481 – media-gfx/gimp failed to build in clang, incompatible pointer to integer conversion

Bug 886481 - media-gfx/gimp failed to build in clang, incompatible pointer to integer conversion

Summary: media-gfx/gimp failed to build in clang, incompatible pointer to integer conv...

Status:	RESOLVED DUPLICATE of bug 875413

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Sergey Torokhov

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:

Reported:	2022-12-17 16:48 UTC by Sheng Yu
Modified:	2022-12-18 09:35 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
patch (gimp_clang_integer_conversion.patch,488 bytes, patch) 2022-12-17 16:49 UTC, Sheng Yu	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Sheng Yu 2022-12-17 16:48:54 UTC

file-dicom.c:605:26: error: incompatible pointer to integer conversion returning 'void *' from a function with result type 'gint32' (aka 'int') [-Wint-conversion]
                  return NULL;
                         ^~~~
/usr/lib/llvm/15/bin/../../../../lib/clang/15.0.5/include/stddef.h:89:16: note: expanded from macro 'NULL'
#  define NULL ((void*)0)
               ^~~~~~~~~~


Reproducible: Always

Comment 1 Sheng Yu 2022-12-17 16:49:36 UTC

Created attachment 843221 [details, diff]
patch

Comment 2 Sam James archtester

2022-12-18 00:43:37 UTC


*** This bug has been marked as a duplicate of bug 875413 ***

Comment 3 Daniel Novomeský 2022-12-18 08:08:25 UTC

The patch is not OK.
Instead return (gint32) NULL; use
return -1;

Comment 4 Sergey Torokhov 2022-12-18 09:35:31 UTC

(In reply to Daniel Novomeský from comment #3)
> The patch is not OK.
> Instead return (gint32) NULL; use
> return -1;

Daniel thank you for your offered patch for upstream. I saw all these issues and don't ignore it. I just can't reach my PC for careful retesting it :( I very hope to review all gimp related issues next week and report unresolved to upstream too.