Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 886265 - media-gfx/darktable-4.2.1 adds -Werror flag on its own
Summary: media-gfx/darktable-4.2.1 adds -Werror flag on its own
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Marek Szuba
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2022-12-16 08:23 UTC by Agostino Sarubbo
Modified: 2023-02-28 10:42 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,43.26 KB, application/x-xz)
2022-12-16 08:23 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-16 08:23:53 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-gfx/darktable-4.0.1-r1 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: ci)

NOTE:
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-16 08:23:55 UTC
Created attachment 842969 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Comment 2 Agostino Sarubbo gentoo-dev 2022-12-24 08:55:04 UTC
ci has reproduced this issue with version 4.2.0 - Updating summary.
Comment 3 Agostino Sarubbo gentoo-dev 2023-02-26 17:42:11 UTC
ci has reproduced this issue with version 4.2.1 - Updating summary.
Comment 4 Larry the Git Cow gentoo-dev 2023-02-28 10:42:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a756e1d067399e45d2096f1e97c38ebedf13b1a4

commit a756e1d067399e45d2096f1e97c38ebedf13b1a4
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2023-02-28 09:56:44 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2023-02-28 10:42:31 +0000

    media-gfx/darktable: squash -Werror in rawspeed
    
    Darktable as a whole only enables -Werror by default while building in a
    Git working tree, rawspeed however has a separate option to control this
    which is on by default.
    
    Closes: https://bugs.gentoo.org/886265
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 media-gfx/darktable/darktable-4.2.1.ebuild | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)