Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 885743 - Restore write access to repo/proj/dotnet.git
Summary: Restore write access to repo/proj/dotnet.git
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Infrastructure
Classification: Unclassified
Component: Git (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Infrastructure
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-13 10:05 UTC by Arsen Shnurkov
Modified: 2022-12-15 19:31 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arsen Shnurkov 2022-12-13 10:05:08 UTC
This package exists in main tree, so it should be deleted in ::dotnet repository.

right now it prevent cache regeneration:
https://qa-reports.gentoo.org/output/repos/dotnet.html


$ pmaint --config /var/lib/repo-mirror-ci/data/etc/portage regen --use-local-desc --pkg-desc-index -t 32 dotnet
 * www-servers/xsp-4.6: failed sourcing ebuild: inherit requires unknown eclass: user.eclass
	[FATAL]
 * Cache regen failed with 1

I am unable to remove it myself, because I don't remember how to do that, and obvious steps give:

/var/db/repos/dotnet $ git push

FATAL -- ACCESS DENIED
Repo            repo/proj/dotnet                                            
User            Arsen.Shnurkov@gmail.com                                    
Stage           Before git was called                                       
Operation       Repo write                                                  

FATAL: W any repo/proj/dotnet Arsen.Shnurkov@gmail.com DENIED by fallthru
(or you mis-spelled the reponame)
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.


Reproducible: Always
Comment 1 Arsen Shnurkov 2022-12-13 10:09:05 UTC
And my access (https://bugs.gentoo.org/843380) was removed without notice:

$ ssh git@git.gentoo.org info | grep " W"
 R W	proj/test
Comment 2 Mike Gilbert gentoo-dev 2022-12-14 22:26:09 UTC
Your access was removed because you hadn't pushed anything since 2016. Should be a simple matter to restore it.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-12-14 22:34:11 UTC
Maybe an error if missed https://github.com/gentoo/dotnet/commit/79b95c4f839396323d4dbd3033be3de3fb7cbaa8
Comment 4 Mike Gilbert gentoo-dev 2022-12-14 22:39:22 UTC
Indeed, it may have been an error; I was just quoting ajak's email to gentoo-core.
Comment 5 John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2022-12-14 23:56:21 UTC
Ah, you're not using your email in the git author/S-o-b. That'd be why I missed it. Please use that email instead of a fake one.
Comment 6 John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2022-12-15 00:05:49 UTC
Your access should be restored. Again, please use the correct email address. I don't think the hooks are supposed to allow what you're doing.
Comment 7 Arsen Shnurkov 2022-12-15 03:21:39 UTC
yes, restored.

I used long fake email, because if i use a short one it doesn't work:

/var/db/repos/dotnet $ git push
Enumerating objects: 3, done.
Counting objects: 100% (3/3), done.
Delta compression using up to 4 threads
Compressing objects: 100% (2/2), done.
Writing objects: 100% (2/2), 989 bytes | 989.00 KiB/s, done.
Total 2 (delta 1), reused 0 (delta 0), pack-reused 0
remote: FATAL: VREF/proj-gentoo-06-copyright: helper program exit status 256
remote: 312da2cd3c58aec9b3f2f485cb83771121564b4b: no Signed-off-by line matching committer's e-mail address found!
remote:   expected: ArsenShnurkov@users.noreply.github.com
remote:   last found: Arsen.Shnurkov@gmail.com
remote: 
remote: Please make sure to read the copyright policy before adding Signed-off-by!
remote:   https://www.gentoo.org/glep/glep-0076.html
remote: error: hook declined to update refs/heads/master
To git+ssh://git.gentoo.org/repo/proj/dotnet.git
 ! [remote rejected] master -> master (hook declined)
error: failed to push some refs to 'git+ssh://git.gentoo.org/repo/proj/dotnet.git'
Comment 8 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-12-15 03:32:48 UTC
No, the issue is that your git author has to align with Signed-off-by.
Comment 9 Arsen Shnurkov 2022-12-15 03:34:38 UTC
I agree. I need to reread 
https://docs.github.com/ru/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address

and revert email in git settings, because commit goes to gentoo, not github.
Comment 10 Arsen Shnurkov 2022-12-15 03:41:14 UTC
But that email will become visible on github after synchronization between gentoo and github. So I need another email (preferably on gentoo project). I don't have one, because I am not a gentoo developer. And I am not a gentoo developer because there are no mentors who are willing to assign that status to me.
Comment 11 John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2022-12-15 03:50:06 UTC
Arsen.Shnurkov AT gmail.com is already on Github. See 7a97cafed5761149784e0b0ac47983ce9e88a1a4 for example. You're not hiding anything by keeping it out of your commits.
Comment 12 Arsen Shnurkov 2022-12-15 19:15:18 UTC
In that 2016 i just had no knowledge about that feature. Later I learned it.
If github provide that security guideline, why am i to act differently?
Comment 13 Mike Gilbert gentoo-dev 2022-12-15 19:23:40 UTC
(In reply to Arsen Shnurkov from comment #12)
> In that 2016 i just had no knowledge about that feature. Later I learned it.
> If github provide that security guideline, why am i to act differently?

You don't push to Github; you push to Gentoo's infra and we mirror it to Github.

Gentoo would strongly prefer that you not use a fake/masked email address when committing. I'm not sure if we have that written down anywhere as policy, but if you insist we can make an official issue out of it.
Comment 14 John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2022-12-15 19:31:41 UTC
The lack of sufficient validation in our git hooks is what's raised in bug 882435. As far as I can tell it's not expected that our hooks allow the usage of emails that aren't what gitolite knows.