Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 885349 - media-libs/libgpod-0.8.3-r5 fails to compile (CLANG-STRICTER-SYSTEM): generic-callout.c:667:49: error: parameter usb_device_number was not declared, defaults to int; ISO C99 and later do not support implicit int [-Werror,-Wimplicit-int]
Summary: media-libs/libgpod-0.8.3-r5 fails to compile (CLANG-STRICTER-SYSTEM): generic...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard: fixed in 0.8.3-r6
Keywords: PullRequest
Depends on:
Blocks: c99-porting
  Show dependency tree
 
Reported: 2022-12-10 14:09 UTC by Agostino Sarubbo
Modified: 2024-10-29 17:25 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (build.log,116.71 KB, text/plain)
2022-12-10 14:09 UTC, Agostino Sarubbo 		Details
libgpod-0.8.3-no-implicit-int-args.patch (libgpod-0.8.3-no-implicit-int-args.patch,987 bytes, patch)
2022-12-11 01:41 UTC, Peter Levine 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-10 14:09:43 UTC 
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-libs/libgpod-0.8.3-r5 fails to compile (CLANG-STRICTER-SYSTEM).
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-10 14:09:45 UTC 
Created attachment 841263 [details]
build.log

build log and emerge --info
Comment 2 Peter Levine 2022-12-11 01:41:41 UTC 
Created attachment 841311 [details, diff]
libgpod-0.8.3-no-implicit-int-args.patch

Explicitly declares args as gint (aka int).


PR submitted to https://sourceforge.net/p/gtkpod/libgpod/merge-requests/2/
Comment 3 Larry the Git Cow gentoo-dev 2022-12-16 05:11:01 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6ab939e7cafa7b560904b3839eaeabb3adafca7e

commit 6ab939e7cafa7b560904b3839eaeabb3adafca7e
Author:     Pascal Jäger <pascal.jaeger@leimstift.de>
AuthorDate: 2022-12-11 19:47:29 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-12-16 05:08:50 +0000

    media-libs/libgpod: fix build for clang16, fix other bugs
    
    - rm /tmp only when USE=udev
    - call udev_reload when USE=udev
    - fix implicit int
    
    Closes: https://bugs.gentoo.org/822144
    Closes: https://bugs.gentoo.org/847415
    Closes: https://bugs.gentoo.org/885349
    Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de>
    Closes: https://github.com/gentoo/gentoo/pull/28640
    Signed-off-by: Sam James <sam@gentoo.org>

 .../libgpod/files/libgpod-0.8.3-implicit-int.patch | 19 ++++++
 media-libs/libgpod/libgpod-0.8.3-r6.ebuild         | 78 ++++++++++++++++++++++
 2 files changed, 97 insertions(+)