Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 883069 - app-office/dia-0.97.3-r2 fails to compile (CLANG-STRICTER-SYSTEM): diapsft2renderer.c:299:7: error: incompatible function pointer types initializing FT_Outline_MoveToFunc (aka int ()(const struct FT_Vector_ , void )) with an expression of type int (FT_Ve
Summary: app-office/dia-0.97.3-r2 fails to compile (CLANG-STRICTER-SYSTEM): diapsft2re...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard: fixed in 0.97.3-r3
Keywords: PATCH
: 935339 (view as bug list)
Depends on:
Blocks: c99-porting
  Show dependency tree
 
Reported: 2022-11-25 20:37 UTC by Agostino Sarubbo
Modified: 2024-10-29 16:09 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log.xz (build.log.xz,566.52 KB, application/x-xz)
2022-11-25 20:37 UTC, Agostino Sarubbo 		Details
dia-0.97.3-clang17.patch (dia-0.97.3-clang17.patch,3.95 KB, patch)
2024-05-16 19:23 UTC, Markus Peloquin 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-11-25 20:37:16 UTC 
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-office/dia-0.97.3-r1 fails to compile (CLANG-STRICTER-SYSTEM).
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting
Comment 1 Agostino Sarubbo gentoo-dev 2022-11-25 20:37:21 UTC 
Created attachment 836803 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Comment 2 Markus Peloquin 2024-05-16 19:23:01 UTC 
Created attachment 893083 [details, diff]
dia-0.97.3-clang17.patch

This now affects clang-17 by default, no strict mode needed. Fix was pretty trivial.
Comment 3 Agostino Sarubbo gentoo-dev 2024-06-08 16:23:04 UTC 
ci has reproduced this issue with version 0.97.3-r2 - Updating summary.
Comment 4 email200202 2024-06-09 03:00:44 UTC 
app-office/dia-0.97.3-r2 failed to merge in the latest world update. 

/usr/include/libxml2/libxml/parser.h:1010:17: note: declared here
1010 |                 xmlSAXUserParseMemory   (xmlSAXHandlerPtr sax,
|                 ^~~~~~~~~~~~~~~~~~~~~
custom_object.c: In function 'custom_setup_properties':
custom_object.c:382:49: error: passing argument 1 of '(info->props + (sizetype)((long unsigned int)i * 88))->ops->get_data_size' from incompatible pointer type [-Wincompatible-pointer-types]
Comment 5 Larry the Git Cow gentoo-dev 2024-06-12 05:10:54 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=36ad21f76fa99146973a7635f30226458534913f

commit 36ad21f76fa99146973a7635f30226458534913f
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-06-12 05:07:38 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-06-12 05:10:22 +0000

    app-office/dia: fix various modern C issues
    
    ... with backports, although via Fedora.
    
    Closes: https://bugs.gentoo.org/883069
    Signed-off-by: Sam James <sam@gentoo.org>

 app-office/dia/dia-0.97.3-r3.ebuild       |  93 ++++++++++
 app-office/dia/files/dia-0.97.3-c99.patch | 284 ++++++++++++++++++++++++++++++
 2 files changed, 377 insertions(+)
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-07-02 10:38:27 UTC 
*** Bug 935339 has been marked as a duplicate of this bug. ***