Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 882897 - net-fs/samba-4.15.12-r2: stabilisation
Summary: net-fs/samba-4.15.12-r2: stabilisation
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Stabilization (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Gentoo's SAMBA Team
URL:
Whiteboard:
Keywords: CC-ARCHES
Depends on:
Blocks: 864983 CVE-2022-3592 880437
  Show dependency tree
 
Reported: 2022-11-25 06:26 UTC by Kosmas
Modified: 2023-01-06 18:05 UTC (History)
0 users

See Also:
Package list:
net-fs/samba-4.15.12-r2
Runtime testing required: ---
nattka: sanity-check+


Attachments
Emerge Info and Build Log (info.zip,466.73 KB, application/zip)
2022-11-25 06:26 UTC, Kosmas
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kosmas 2022-11-25 06:26:20 UTC
Created attachment 836635 [details]
Emerge Info and Build Log

Hello Team,

It seems that the new update of dev-libs/icu-72.1 in portage breaks net-fs/samba-4.15.9-r1 build.

Version 4.17.3 is available upstream, while the latest version in the Gentoo tree is 4.16.7. We may need to update it in portage.

Kind Regards,
Kosmas.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-11-25 06:29:30 UTC
(You could've reopened the other bug, fwiw)

./../source4/kdc/mit-kdb/kdb_samba_policies.c: In function ‘kdb_samba_db_sign_auth_data’:
../../source4/kdc/mit-kdb/kdb_samba_policies.c:335:31: error: ‘KRB5_KDB_FLAG_CLIENT_REFERRALS_ONLY’ undeclared (first use in this function); did you mean ‘KRB5_KDB_FLAG_REFERRAL_OK’?
  335 |         is_as_req = ((flags & KRB5_KDB_FLAG_CLIENT_REFERRALS_ONLY) != 0);
      |                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                               KRB5_KDB_FLAG_REFERRAL_OK
../../source4/kdc/mit-kdb/kdb_samba_policies.c:335:31: note: each undeclared identifier is reported only once for each function it appears in
../../source4/kdc/mit-kdb/kdb_samba_policies.c:412:35: error: ‘KRB5_KDB_FLAG_INCLUDE_PAC’ undeclared (first use in this function); did you mean ‘KRB5_KDB_FLAG_CLIENT’?
  412 |         if (is_as_req && (flags & KRB5_KDB_FLAG_INCLUDE_PAC) != 0) {
      |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~
      |                                   KRB5_KDB_FLAG_CLIENT

../../source4/kdc/mit-kdb/kdb_samba.c:169:10: error: ‘kdb_vftabl’ {aka ‘struct _kdb_vftabl’} has no member named ‘sign_authdata’
  169 |         .sign_authdata             = kdb_samba_db_sign_auth_data,
      |          ^~~~~~~~~~~~~

Looks like it's system-krb5 again. I think this is a duplicate of bug 864983, but we do need to stable newer samba, so let's repurpose this bug for that.
Comment 2 Kosmas 2022-11-25 06:50:30 UTC
You are right Sam, (for both comments)

It seems that the icu version is not the problem, but the system-krb5.
I tried to build it with 1 job (MAKEOPTS="-j1") to make sure that it only fails there, and it is exactly what you saw:


../../source4/kdc/mit_samba.c: In function ‘mit_samba_context_init’:
../../source4/kdc/mit_samba.c:93:9: warning: ‘tevent_loop_allow_nesting’ is deprecated [-Wdeprecated-declarations]
   93 |         tevent_loop_allow_nesting(base_ctx.ev_ctx);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/ldb.h:51,
                 from ../../source4/dsdb/samdb/samdb.h:35,
                 from ../../source4/kdc/mit_samba.c:26:
/usr/include/tevent.h:2354:6: note: declared here
 2354 | void tevent_loop_allow_nesting(struct tevent_context *ev) _DEPRECATED_;
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~
../../source4/kdc/mit_samba.c: In function ‘mit_samba_get_principal’:
../../source4/kdc/mit_samba.c:232:22: error: ‘KRB5_KDB_FLAG_CANONICALIZE’ undeclared (first use in this function); did you mean ‘KRB5_GC_CANONICALIZE’?
  232 |         if (kflags & KRB5_KDB_FLAG_CANONICALIZE) {
      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~
      |                      KRB5_GC_CANONICALIZE
../../source4/kdc/mit_samba.c:232:22: note: each undeclared identifier is reported only once for each function it appears in
../../source4/kdc/mit_samba.c:235:23: error: ‘KRB5_KDB_FLAG_CLIENT_REFERRALS_ONLY’ undeclared (first use in this function); did you mean ‘KRB5_KDB_FLAG_REFERRAL_OK’?
  235 |         if (kflags & (KRB5_KDB_FLAG_CLIENT_REFERRALS_ONLY |
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                       KRB5_KDB_FLAG_REFERRAL_OK
../../source4/kdc/mit_samba.c:236:23: error: ‘KRB5_KDB_FLAG_INCLUDE_PAC’ undeclared (first use in this function); did you mean ‘KRB5_KDB_FLAG_CLIENT’?
  236 |                       KRB5_KDB_FLAG_INCLUDE_PAC)) {
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~
      |                       KRB5_KDB_FLAG_CLIENT

Waf: Leaving directory `/tmp/portage/net-fs/samba-4.15.9-r1/work/samba-4.15.9-abi_x86_64.amd64/bin/default'


Let me know if there is anything more that I can help with.

Kind Regards,
Kosmas.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-11-25 07:15:51 UTC
arm done
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-11-25 07:15:53 UTC
arm64 done
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-11-25 07:25:05 UTC
amd64 done
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-11-25 07:28:59 UTC
x86 done
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-11-25 07:31:54 UTC
(In reply to Kosmas from comment #2)
> 
> Let me know if there is anything more that I can help with.
> 
> Kind Regards,
> Kosmas.

Thanks! Nothing more should be needed -- we now wait for the testers to do the various arches (amd64 was just done now -- so when you sync, all should be good).
Comment 8 Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2022-11-25 07:51:28 UTC
ppc64 done
Comment 9 Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2022-11-25 07:51:58 UTC
ppc done
Comment 10 Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2022-11-25 07:53:47 UTC
sparc done

all arches done