Bug 882805 – app-crypt/seahorse-43.0: build failure with clang >= 15 due to default -Werror=int-conversion (operation.c:536:2: error: incompatible pointer to integer conversion returning 'void *' from a function with result type 'gboolean' (aka 'int'))

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Bryce Glover 2022-11-24 19:18:12 UTC]

Attempting to upgrade `app-crypt/seahorse` from v42.0-r1 to v43.0 kept failing.  

Reproducible: Always

Steps to Reproduce:
Run either of:  

 - `emerge --verbose --update --deep --newuse --changed-slot=y --with-bdeps=y @world` with `app-crypt/seahorse` in the set of packages selected for upgrading
 - `emerge --verbose --update --deep --newuse --changed-slot=y --with-bdeps=y app-crypt/seahorse`
Actual Results:  
```
⁝
[190/263] clang -Issh/libseahorse-ssh.a.p -Issh -I../seahorse-43.0/ssh -Icommon -I../seahorse-43.0/common -I. -I../seahorse-43.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -I/usr/include/gcr-3 -I/usr/include/gck-1 -I/usr/include/p11-kit-1 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/lzo -I/usr/include/libpng16 -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/libhandy-1 -fcolor-diagnostics -D_FILE_OFFSET_BITS=64 -w -DGCR_API_SUBJECT_TO_CHANGE -DGCK_API_SUBJECT_TO_CHANGE -DSECRET_WITH_UNSTABLE -include config.h -Wno-unused-parameter -Wno-missing-field-initializers -march=native -mtune=native -O2 -pipe -flto=thin -fPIC -pthread -MD -MQ ssh/libseahorse-ssh.a.p/meson-generated_operation.c.o -MF ssh/libseahorse-ssh.a.p/meson-generated_operation.c.o.d -o ssh/libseahorse-ssh.a.p/meson-generated_operation.c.o -c ssh/libseahorse-ssh.a.p/operation.c
FAILED: ssh/libseahorse-ssh.a.p/meson-generated_operation.c.o
clang -Issh/libseahorse-ssh.a.p -Issh -I../seahorse-43.0/ssh -Icommon -I../seahorse-43.0/common -I. -I../seahorse-43.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -I/usr/include/gcr-3 -I/usr/include/gck-1 -I/usr/include/p11-kit-1 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/lzo -I/usr/include/libpng16 -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/libhandy-1 -fcolor-diagnostics -D_FILE_OFFSET_BITS=64 -w -DGCR_API_SUBJECT_TO_CHANGE -DGCK_API_SUBJECT_TO_CHANGE -DSECRET_WITH_UNSTABLE -include config.h -Wno-unused-parameter -Wno-missing-field-initializers -march=native -mtune=native -O2 -pipe -flto=thin -fPIC -pthread -MD -MQ ssh/libseahorse-ssh.a.p/meson-generated_operation.c.o -MF ssh/libseahorse-ssh.a.p/meson-generated_operation.c.o.d -o ssh/libseahorse-ssh.a.p/meson-generated_operation.c.o -c ssh/libseahorse-ssh.a.p/operation.c
ssh/libseahorse-ssh.a.p/operation.c:536:2: error: incompatible pointer to integer conversion returning 'void *' from a function with result type 'gboolean' (aka 'int') [-Wint-conversion]
        g_return_val_if_fail (_data_->_tmp0_, NULL);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated. 
⁝
ninja: build stopped: subcommand failed.
 * ERROR: app-crypt/seahorse-43.0::gentoo failed (compile phase):
 *   compile failed
⁝
```

Expected Results:  
 - A successful `emerge` run for `app-crypt/seahorse`.  

 - This is on a Gentoo instance I have running under Windows Subsystem for Linux v2 on 64-bit Windows 11 Pro 22H2, build 22621.819, with Windows Feature Experience Pack 1000.22636.1000.0.  
 - I was able to work around this issue by adding the following entry to `/etc/portage/package.env`:  

   ```
   app-crypt/seahorse compiler-gcc
   ```

   then trying again.  
 - I'll attach my logs to this issue thread shortly.

[Comment 1 Bryce Glover 2022-11-24 19:23:56 UTC]

Created attachment 836529 [details]
`emerge --info` output

[Comment 2 Bryce Glover 2022-11-24 19:25:30 UTC]

Created attachment 836531 [details]
`build.log`

[Comment 3 Sam James 2022-11-25 03:04:24 UTC]

Could you forward this to upstream at https://gitlab.gnome.org/GNOME/seahorse/-/issues?

[Comment 4 Bryce Glover 2022-11-25 22:27:37 UTC]

Of course; will do.

[Comment 5 Bryce Glover 2022-11-25 22:50:58 UTC]

All right, that's now done as upstream issue #359:  <https://gitlab.gnome.org/GNOME/seahorse/-/issues/359>.

[Comment 6 Sam James 2022-12-24 11:44:45 UTC]

(In reply to Bryce Glover from comment #5)
> All right, that's now done as upstream issue #359: 
> <https://gitlab.gnome.org/GNOME/seahorse/-/issues/359>.

Thank you!

[Comment 7 Bryce Glover 2022-12-26 22:45:01 UTC]

(In reply to Sam James from comment #6)
> (In reply to Bryce Glover from comment #5)
> > All right, that's now done as upstream issue #359: 
> > <https://gitlab.gnome.org/GNOME/seahorse/-/issues/359>.
> 
> Thank you!

Of course; no problem, and you're welcome.

[Comment 8 ppw0 2023-10-03 03:36:21 UTC]

Created attachment 872069 [details, diff]
seahorse-43.0-r3-clang-17.patch

Hi,

this patch ought to allow building seahorse-43.0-r3 with clang-17.

[Comment 9 Sam James 2023-12-06 10:41:58 UTC]

(In reply to ppw0 from comment #8)
> Created attachment 872069 [details, diff] [details, diff]
> seahorse-43.0-r3-clang-17.patch
> 
> Hi,
> 
> this patch ought to allow building seahorse-43.0-r3 with clang-17.

Could you send it upstream please?

[Comment 10 ppw0 2023-12-06 12:44:10 UTC]

https://gitlab.gnome.org/GNOME/seahorse/-/merge_requests/220

[Comment 11 YOSHIOKA Takuma 2024-05-19 22:49:26 UTC]

Now sys-devel/gcc-14.1.1_p20240518 also fails to compile this with this error.
With the patch attached to comment 8, it successfully compiles.

[Comment 12 Larry the Git Cow 2024-06-03 07:56:08 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c8e1df8cd659084771c6027fbdb1255934d1f996

commit c8e1df8cd659084771c6027fbdb1255934d1f996
Author:     Sam James <[e-mail]>
AuthorDate: 2024-06-03 07:54:06 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-06-03 07:54:45 +0000

    app-crypt/seahorse: fix modern C issues
    
    For c99-2.patch, we backport an upstream commit as Fedora did, as it
    felt like a better idea.
    
    Closes: https://bugs.gentoo.org/882805
    Closes: https://bugs.gentoo.org/919323
    Closes: https://bugs.gentoo.org/919458
    Closes: https://bugs.gentoo.org/924997
    Signed-off-by: Sam James <[e-mail]>

 app-crypt/seahorse/files/seahorse-43.0-c99-2.patch | 517 +++++++++++++++++++++
 app-crypt/seahorse/files/seahorse-43.0-c99.patch   |  21 +
 app-crypt/seahorse/seahorse-43.0-r4.ebuild         |  87 ++++
 3 files changed, 625 insertions(+)