Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 881777 - sci-calculators/bc-gh-6.1.1 does not respect LDFLAGS
Summary: sci-calculators/bc-gh-6.1.1 does not respect LDFLAGS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gavin D. Howard
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: ldflags
  Show dependency tree
 
Reported: 2022-11-18 09:08 UTC by Agostino Sarubbo
Modified: 2022-11-19 06:04 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,85.20 KB, text/plain)
2022-11-18 09:08 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-11-18 09:08:44 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-calculators/bc-gh-6.1.1 does not respect LDFLAGS.
Discovered on: amd64 (internal ref: ci)

NOTE:
To reproduce this issue you may want to set LDFLAGS="${LDFLAGS} -Wl,--defsym=__gentoo_check_ldflags__=0". If this is not something about c/c++ context you may want to see this bug as an hint to hide the QA warning (with QA_FLAGS_IGNORED) where is not possible to respect LDFLAGS.
Comment 1 Agostino Sarubbo gentoo-dev 2022-11-18 09:08:47 UTC
Created attachment 833281 [details]
build.log

build log and emerge --info
Comment 2 Ionen Wolkens gentoo-dev 2022-11-18 09:11:57 UTC
ftr, as mentioned on PR, this is a side-effect of pre-stripping (LDFLAGS are technically respected)
Comment 3 Larry the Git Cow gentoo-dev 2022-11-19 06:04:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=af57a51586af3149c49d1584dfc724f74312eaff

commit af57a51586af3149c49d1584dfc724f74312eaff
Author:     Gavin Howard <gavin@yzena.com>
AuthorDate: 2022-11-18 14:41:12 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2022-11-19 06:03:20 +0000

    sci-calculators/bc-gh: Fix QA issues with pre-stripping
    
    The problem was that the argument for disabling pre-stripping came
    *before* the predefined build, which then overrode it. I just reversed
    the arguments; this is what I should have done at the beginning anyway
    since that's how the predefined build arguments were designed.
    
    Signed-off-by: Gavin D. Howard <gavin@yzena.com>
    Closes: https://bugs.gentoo.org/881777
    Closes: https://bugs.gentoo.org/881779
    Closes: https://github.com/gentoo/gentoo/pull/28325
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 sci-calculators/bc-gh/bc-gh-6.1.1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)