Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 881123 - media-libs/lsp-plugins: Global X flag not honored
Summary: media-libs/lsp-plugins: Global X flag not honored
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Matthew Thode ( prometheanfire )
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-12 18:00 UTC by marius
Modified: 2024-07-19 13:36 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description marius 2022-11-12 18:00:31 UTC
The package appears to accept the global X flag, however it is not honored as dependencies are required with hardwired X flag.

Reproducible: Always
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-11-15 06:42:58 UTC
Really, I think it's more that X should be called gui or something, as it just controls XDG bits. I don't think the X deps on any of these things are necessarily then optional.
Comment 2 Peter Levine 2022-12-17 10:06:22 UTC
The X USE flag enables `xdg` in the FEATURES variable that's passed to emake.  The only purpose of it is to install the icons and all of the desktop files for gui menus.  However, if the 'jack' USE flag is not enabled with the `X` flag, it doesn't install any binaries referenced in those desktop files. So launching any of those programs from the desktop entry results in something like "Could not find the program 'lsp-plugins-multisampler-x24-do'", for example.

It makes sense to keep the X flag, or whatever named flag that becomes, because there are a tremendous number of desktop entries that get dumped in the "Multimedia" category that some users would prefer to avoid.  But including `xdg` in FEATURES should depend on both that flag and the 'jack' flag.
Comment 3 marius 2024-07-19 13:36:47 UTC
I am running into a similar issue, which I have documented [here](https://github.com/lsp-plugins/lsp-plugins/issues/401#issuecomment-2237499582):

```
  (x11-libs/cairo-1.18.0:0/0::gentoo, ebuild scheduled for merge) USE="X glib (-aqua) (-debug) -gtk-doc -test" ABI_X86="(64) -32 (-x32)" pulled in by
    x11-libs/cairo[X] required by (media-libs/lsp-plugins-1.2.14:0/0::gentoo, ebuild scheduled for merge) USE="lv2 -X -doc -jack -ladspa -test -vst" ABI_X86="(64)"
                   ^            
```

I first thought that it was an issue with lsp-plugins, hence I commented on their GitHub first, but as explained [here](https://github.com/lsp-plugins/lsp-plugins/issues/401#issuecomment-2238734424) it seems like it's a packaging issue.

I am trying to build without `jack`:

```
 * Found these USE flags for media-libs/lsp-plugins-1.2.14:
 U I
 - - X      : Add support for X11
 - - doc    : Add extra documentation (API, Javadoc, etc). It is recommended to enable per package instead of globally
 - - jack   : Add support for the JACK Audio Connection Kit
 - - ladspa : Enable the ability to support ladspa plugins
 + - lv2    : Build lv2 plugins
 - - test   : Enable dependencies and/or preparations necessary to run tests (usually controlled by FEATURES=test but can be toggled
              independently)
 - - vst    : Support LinuxVST plugins
```