https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: sys-fs/multipath-tools-0.9.3 fails tests (LTO-SYSTEM). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: (LTO-SYSTEM) in the summary means that bug was found on a machine that runs lto but this bug MAY or MAY NOT BE related to lto. This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Created attachment 829943 [details] build.log build log and emerge --info
commit 1bb1ddae1e788f78eb2f7dd47f2f2f92e5fc7a94 Author: David Seifert <soap@gentoo.org> Date: Thu Mar 23 16:54:48 2023 +0100 sys-fs/multipath-tools: remove -Werror from build Closes: https://bugs.gentoo.org/902811 Signed-off-by: David Seifert <soap@gentoo.org>
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b711a7a20e8b85a794d9d706cd1a76d4e4401b45 commit b711a7a20e8b85a794d9d706cd1a76d4e4401b45 Author: Sam James <sam@gentoo.org> AuthorDate: 2024-03-17 05:52:59 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-03-17 05:52:59 +0000 sys-fs/multipath-tools: filter LTO It uses -Wl,--wrap and wrap_*. openSUSE filter LTO too. Bug: https://bugs.gentoo.org/880567 Signed-off-by: Sam James <sam@gentoo.org> sys-fs/multipath-tools/multipath-tools-0.9.7-r1.ebuild | 2 ++ sys-fs/multipath-tools/multipath-tools-0.9.7.ebuild | 2 ++ 2 files changed, 4 insertions(+)
