Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 879633 - app-metrics/collectd: possible configure breakage with Clang 16
Summary: app-metrics/collectd: possible configure breakage with Clang 16
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Conrad Kostecki
URL: https://github.com/collectd/collectd/...
Whiteboard:
Keywords:
Depends on:
Blocks: 906027
  Show dependency tree
 
Reported: 2022-11-04 22:06 UTC by Matt Jolly
Modified: 2023-12-04 07:32 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
clang-14.log (clang-14.log,318.89 KB, text/plain)
2022-11-04 22:07 UTC, Matt Jolly
Details
clang-15.log (clang-15.log,318.89 KB, text/plain)
2022-11-04 22:07 UTC, Matt Jolly
Details
clang.diff (clang.diff,161.13 KB, text/plain)
2022-11-04 22:07 UTC, Matt Jolly
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Jolly gentoo-dev 2022-11-04 22:06:42 UTC
This package has been identified via automation as potentially impacted by upcoming Clang 16 changes.
The following have been identified as potential issues:

[-Werror,-Wcompound-token-split-by-macro]

[-Werror,-Wcompound-token-split-by-macro]
error: '(' and '{' tokens introducing statement expression appear in different macro expansion contexts [-Werror,-Wcompound-token-split-by-macro]
error: '}' and ')' tokens terminating statement expression appear in different macro expansion contexts [-Werror,-Wcompound-token-split-by-macro]
Comment 1 Matt Jolly gentoo-dev 2022-11-04 22:07:01 UTC
Created attachment 827161 [details]
clang-14.log

build log
Comment 2 Matt Jolly gentoo-dev 2022-11-04 22:07:22 UTC
Created attachment 827163 [details]
clang-15.log

build log
Comment 3 Matt Jolly gentoo-dev 2022-11-04 22:07:36 UTC
Created attachment 827165 [details]
clang.diff

build log
Comment 4 Conrad Kostecki gentoo-dev 2023-01-24 01:18:53 UTC
@sam: Do you have an idea for fix? Upstream ask, if we could fill a PR.
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-01-24 01:20:19 UTC
I'll take a look.
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-01-28 03:36:20 UTC
Left a comment at https://github.com/collectd/collectd/issues/4061#issuecomment-1407274858. There's a mix of issues.
Comment 7 Larry the Git Cow gentoo-dev 2023-04-14 03:39:38 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=eff1ccb300e56b56ceea1fa204946647366afff3

commit eff1ccb300e56b56ceea1fa204946647366afff3
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-04-14 02:50:58 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-04-14 03:23:02 +0000

    app-metrics/collectd: fix configure w/ clang 16
    
    Closes: https://bugs.gentoo.org/879633
    Closes: https://bugs.gentoo.org/900392
    Signed-off-by: Sam James <sam@gentoo.org>

 ...-5.12.0-r7.ebuild => collectd-5.12.0-r8.ebuild} |   1 +
 .../files/collectd-5.12.0-clang16-configure.patch  | 127 +++++++++++++++++++++
 2 files changed, 128 insertions(+)
Comment 8 Conrad Kostecki gentoo-dev 2023-04-16 00:16:43 UTC
Thank you!
Comment 9 Larry the Git Cow gentoo-dev 2023-12-04 07:32:49 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=70e9a9462d2ab905cc2daeba69bc3a502de0729c

commit 70e9a9462d2ab905cc2daeba69bc3a502de0729c
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-12-04 07:32:00 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-12-04 07:32:14 +0000

    app-metrics/collectd: fix another modern c issue in configure (for nut)
    
    Bug: https://bugs.gentoo.org/879633
    Signed-off-by: Sam James <sam@gentoo.org>

 app-metrics/collectd/collectd-5.12.0-r9.ebuild     | 563 +++++++++++++++++++++
 .../collectd/files/collectd-5.12.0-nut-c99.patch   | 143 ++++++
 2 files changed, 706 insertions(+)