Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 879319 - games-strategy/warzone2100-4.3.3-r2 calls cc directly
Summary: games-strategy/warzone2100-4.3.3-r2 calls cc directly
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: tc-directly
  Show dependency tree
 
Reported: 2022-11-03 09:53 UTC by Agostino Sarubbo
Modified: 2023-01-28 05:11 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,61.58 KB, text/plain)
2022-11-03 09:54 UTC, Agostino Sarubbo
Details
1-CMakeError.log (1-CMakeError.log,5.86 KB, text/plain)
2022-11-03 09:54 UTC, Agostino Sarubbo
Details
1-CMakeOutput.log (1-CMakeOutput.log,48 bytes, text/plain)
2022-11-03 09:54 UTC, Agostino Sarubbo
Details
2-CMakeError.log (2-CMakeError.log,11.19 KB, text/plain)
2022-11-03 09:54 UTC, Agostino Sarubbo
Details
2-CMakeOutput.log (2-CMakeOutput.log,49.49 KB, text/plain)
2022-11-03 09:54 UTC, Agostino Sarubbo
Details
3-CMakeOutput.log (3-CMakeOutput.log,60.31 KB, text/plain)
2022-11-03 09:54 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-11-03 09:53:59 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-strategy/warzone2100-4.3.1 calls cc directly.
Discovered on: amd64 (internal ref: ci)

NOTE:
As per QA policy, toolchain tools must not be called directly because they can cause issue in cross-compiling and because is not possible use a different CC implementation (like clang). To reproduce, please use sys-devel/gcc-config[-native-symlinks], sys-devel/binutils-config[-native-symlinks].
Comment 1 Agostino Sarubbo gentoo-dev 2022-11-03 09:54:01 UTC
Created attachment 826845 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-11-03 09:54:02 UTC
Created attachment 826847 [details]
1-CMakeError.log

1-CMakeError.log
Comment 3 Agostino Sarubbo gentoo-dev 2022-11-03 09:54:03 UTC
Created attachment 826849 [details]
1-CMakeOutput.log

1-CMakeOutput.log
Comment 4 Agostino Sarubbo gentoo-dev 2022-11-03 09:54:04 UTC
Created attachment 826851 [details]
2-CMakeError.log

2-CMakeError.log
Comment 5 Agostino Sarubbo gentoo-dev 2022-11-03 09:54:06 UTC
Created attachment 826853 [details]
2-CMakeOutput.log

2-CMakeOutput.log
Comment 6 Agostino Sarubbo gentoo-dev 2022-11-03 09:54:07 UTC
Created attachment 826855 [details]
3-CMakeOutput.log

3-CMakeOutput.log
Comment 7 Agostino Sarubbo gentoo-dev 2022-11-03 09:54:09 UTC
Error(s) that match a know pattern:


  No CMAKE_C_COMPILER could be found.
  No CMAKE_CXX_COMPILER could be found.
Comment 8 Kenton Groombridge gentoo-dev 2022-12-26 06:28:42 UTC
So upstream switched to a new compression format for in-game textures that relies on an external tool to compress those textures in this commit: https://github.com/Warzone2100/warzone2100/commit/7c939b6ebe524dd9d770dca4ee0c7ae1ea7d9e3c

The build system explicitly undefines the compilers in order to trick CMake into using the host compiler to build this tool and then running it directly during the rest of the build. They do this to ensure that the resulting binary for this tool is capable of running on the host system (avoid cross-compilation).

My gut tells me the only real way to fix this is to get this tool in the tree and add it to BDEPEND. (https://github.com/BinomialLLC/basis_universal)
Comment 9 Agostino Sarubbo gentoo-dev 2023-01-22 09:12:51 UTC
ci has reproduced this issue with version 4.3.3-r2 - Updating summary.
Comment 10 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-01-28 04:01:58 UTC
(In reply to Kenton Groombridge from comment #8)
> So upstream switched to a new compression format for in-game textures that
> relies on an external tool to compress those textures in this commit:
> https://github.com/Warzone2100/warzone2100/commit/
> 7c939b6ebe524dd9d770dca4ee0c7ae1ea7d9e3c
> 
> The build system explicitly undefines the compilers in order to trick CMake
> into using the host compiler to build this tool and then running it directly
> during the rest of the build. They do this to ensure that the resulting
> binary for this tool is capable of running on the host system (avoid
> cross-compilation).
> 
> My gut tells me the only real way to fix this is to get this tool in the
> tree and add it to BDEPEND. (https://github.com/BinomialLLC/basis_universal)

I spent a while trying to find this comment after I remembered reading it and couldn't until now. Thanks, I agree. I'll look now.
Comment 11 Larry the Git Cow gentoo-dev 2023-01-28 05:11:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1bdfbf0851a4bf7457d0d63fa59bf8452b1bc455

commit 1bdfbf0851a4bf7457d0d63fa59bf8452b1bc455
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-01-28 05:06:05 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-01-28 05:10:54 +0000

    games-strategy/warzone2100: unbundle basis_universal
    
    Closes: https://bugs.gentoo.org/879319
    Signed-off-by: Sam James <sam@gentoo.org>

 .../warzone2100/warzone2100-4.3.3-r3.ebuild        | 119 +++++++++++++++++++++
 1 file changed, 119 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5144810b848e0bf43bbdd7185e4405f5cc5cea2b

commit 5144810b848e0bf43bbdd7185e4405f5cc5cea2b
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-01-28 05:01:23 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-01-28 05:10:53 +0000

    games-util/basis_universal: new package, add 1.16.3
    
    Bug: https://bugs.gentoo.org/879319
    Signed-off-by: Sam James <sam@gentoo.org>

 games-util/basis_universal/Manifest                |  1 +
 .../basis_universal/basis_universal-1.16.3.ebuild  | 43 ++++++++++++++++++++++
 .../files/basis_universal-1.16.3-fix-RPATH.patch   | 10 +++++
 .../basis_universal-1.16.3-respect-CFLAGS.patch    | 11 ++++++
 games-util/basis_universal/metadata.xml            | 14 +++++++
 5 files changed, 79 insertions(+)