I have just been bitten by an overlooked config update from backuppc-3-3.1 to 4.4.0 in Gentoo portage and lost one month of (mostly unimportant) data. The reason for the loss was the added "--one-file-system" config option to RsyncArgs in BackupPC 4.x that was not present in prior versions. As a result, the data of mounted partitions under a backup destination were no longer updated. Since the main configuration file (conf/config.pl) changes significantly from 3.x to 4.x, this is an easily overlooked change that can potentially lead to very unpleasant results. Especially on existing installations with an existing backup history, the data appears to be backed up properly since one will still see the data backed up pre-4.x. This is a change introduced by upstream, so not directly Gentoo's responsibility. Nevertheless, I feel we should at least print a warning when upgrading from 3.x to 4.x. Reproducible: Always Actual Results: BackupPC 4.x configuration adds the potentially harmful '--one-file-system' option to RsynchArgs. Expected Results: Remove '--one-file-system' configuration option or print a warning when upgrading from existing 3.x installations.
I think this should be done upstream in first place unless it is a pure Gentoo config.
> I think this should be done upstream in first place unless it is a pure Gentoo config.(In reply to Jonas Stein from comment #1) > I think this should be done upstream in first place unless it is a pure > Gentoo config. I agree, however, the issue has been reported to upstream over a year ago and is still open despite several users supporting it (https://github.com/backuppc/backuppc/issues/341). Until upstream fixes this, a warning at the end of an emerge would serve the community well.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0079c90de7cc812c22fe712054b864ce53af59c7 commit 0079c90de7cc812c22fe712054b864ce53af59c7 Author: Dennis Eisele <kernlpanic@dennis-eisele.de> AuthorDate: 2024-04-03 19:18:51 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2024-05-27 13:24:35 +0000 app-backup/backuppc: add warning message Signed-off-by: Dennis Eisele <kernlpanic@dennis-eisele.de> Bug: https://bugs.gentoo.org/878973 Closes: https://github.com/gentoo/gentoo/pull/36083 Signed-off-by: Joonas Niilola <juippis@gentoo.org> app-backup/backuppc/backuppc-4.4.0-r1.ebuild | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
