Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 878869 - =dev-java/java-service-wrapper-3.5.50 directly calls java-run-tool causing net-p2p/freenet to not start
Summary: =dev-java/java-service-wrapper-3.5.50 directly calls java-run-tool causing ne...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Java team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-10-31 10:17 UTC by Thomas Sachau
Modified: 2023-09-11 12:32 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Sachau gentoo-dev 2022-10-31 10:17:35 UTC
It seems noone tested this version neither during version bump nor during stabilization.

This version does directly call java-run-tool instead of just calling the java-symlink. Since java-run-tool does stop with an error when directly called, this means any app using java-service-wrapper wont start at all.

You can actually test this with net-p2p/freenet.

As a result of this, net-p2p/freenet wont even start. You can see the error about java-run-tool in /var/freenet/wrapper.log:

with dev-java/java-service-wrapper-3.5.50:

STATUS | wrapper  | 2022/10/31 10:48:58 | Launching a JVM...
ERROR  | wrapper  | 2022/10/31 10:48:58 | JVM exited while loading the application.
INFO   | jvm 5    | 2022/10/31 10:48:58 | * run-java-tool was invoked directly
INFO   | jvm 5    | 2022/10/31 10:48:58 | * run-java-tool should only be used via symlinks to it
FATAL  | wrapper  | 2022/10/31 10:48:58 | There were 5 failed launches in a row, each lasting less than 300 seconds.  Giving up.
FATAL  | wrapper  | 2022/10/31 10:48:58 |   There may be a configuration problem: please check the logs.
STATUS | wrapper  | 2022/10/31 10:48:59 | <-- Wrapper Stopped

It still runs fine, when you manually downgrade to the previous dev-java/java-service-wrapper-3.5.25-r2.
Comment 1 Thomas Sachau gentoo-dev 2022-10-31 10:18:44 UTC
I suggest to re-add the previous version and mask 3.5.50 until this is fixed.
Comment 2 Horea Christian 2022-12-22 20:41:22 UTC
I get this issue as well, but there is no older version of `dev-java/java-service-wrapper` in ::gentoo.
Comment 3 Arne Babenhauserheide 2022-12-22 22:05:42 UTC
In that case I would suggest to switch to running Freenet without the wrapper. The main service the wrapper provides is auto-update over Freenet, and that is not useful for freenet installed via ebuild.
Comment 4 Arne Babenhauserheide 2022-12-22 22:19:46 UTC
For 1494 that means running Freenet via start-stop-service (if this is still the right tool, Iā€™m a bit out of date on that) using the command 

java -Xmx1500m -Xss512k -Dnetworkaddress.cache.ttl=0 -Dnetworkaddress.cache.negative.ttl=0 --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED   -cp bcprov-jdk15on-1.59.jar:freenet-ext.jar:freenet.jar:jna-4.5.2.jar:jna-platform-4.5.2.jar freenet.node.NodeStarter

(adjusting the jar paths)

For 1495 it will be:

java  -Xmx1500m -Xss512k -Dnetworkaddress.cache.ttl=0 -Dnetworkaddress.cache.negative.ttl=0 --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED -cp bcprov-jdk15on-1.59.jar:freenet-ext.jar:freenet.jar:jna-4.5.2.jar:jna-platform-4.5.2.jar:pebble-3.1.5.jar:unbescape-1.1.6.RELEASE.jar:slf4j-api-1.7.25.jar freenet.node.NodeStarter
Comment 5 Arne Babenhauserheide 2022-12-29 17:29:30 UTC
Version 1495 was released to github and auto-update today. The website info and download will follow.

Freenet now needs the additional dependencies: unbescape, pebble, and slf4j-api.
Comment 6 Larry the Git Cow gentoo-dev 2023-01-05 05:20:59 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=370e220ed49d587ef3e3a22e7eefa9c322f9c14f

commit 370e220ed49d587ef3e3a22e7eefa9c322f9c14f
Author:     Volkmar W. Pogatzki <gentoo@pogatzki.net>
AuthorDate: 2023-01-04 12:36:48 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-01-05 05:14:16 +0000

    dev-java/unbescape: new package, add 1.1.6
    
    Dependency of >=net-p2p/freenet-0.7.5_p1495,
    see https://bugs.gentoo.org/878869#c5
    
    Bug: https://bugs.gentoo.org/878869
    Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
    Closes: https://github.com/gentoo/gentoo/pull/28955
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-java/unbescape/Manifest               |  1 +
 dev-java/unbescape/metadata.xml           | 10 +++++++++
 dev-java/unbescape/unbescape-1.1.6.ebuild | 36 +++++++++++++++++++++++++++++++
 3 files changed, 47 insertions(+)
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-01-22 05:59:37 UTC
commit 07e20f46407339ca15497bad30b4b415b79d1aa8
Author: Thomas Sachau <tommy@gentoo.org>
Date:   Sat Jan 21 14:42:30 2023 +0100

     net-p2p/freenet: Revision bump to workaround bug #878869

     Signed-off-by: Thomas Sachau <tommy@gentoo.org>
Comment 8 Volkmar W. Pogatzki 2023-01-22 11:55:54 UTC
(In reply to Thomas Sachau from comment #0)
> [...]
> 
> It still runs fine, when you manually downgrade to the previous
> dev-java/java-service-wrapper-3.5.25-r2.

Have you tried re-adding the PATCHES array to 3.5.50 with
java-service-wrapper-3.5.25-gentoo-wrapper-defaults.patch from the old version?

The patch would only need to get moved 3.5.25 -> 3.5.50
Comment 9 Larry the Git Cow gentoo-dev 2023-09-11 12:32:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3e54188b375ca5be53aa15fc99ce5e634dad27b8

commit 3e54188b375ca5be53aa15fc99ce5e634dad27b8
Author:     Volkmar W. Pogatzki <gentoo@pogatzki.net>
AuthorDate: 2023-04-22 13:48:22 +0000
Commit:     Florian Schmaus <flow@gentoo.org>
CommitDate: 2023-09-11 12:32:30 +0000

    dev-java/java-service-wrapper: do not directly call java-run-tool
    
    Closes: https://bugs.gentoo.org/878869
    Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
    Signed-off-by: Florian Schmaus <flow@gentoo.org>

 ...ce-wrapper-3.5.25-gentoo-wrapper-defaults.patch | 25 ++++++++++++++++++++++
 ...build => java-service-wrapper-3.5.50-r1.ebuild} |  6 +++++-
 2 files changed, 30 insertions(+), 1 deletion(-)